New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pi" actions are not interrupted #69

Closed
eduncan911 opened this Issue May 27, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@eduncan911

eduncan911 commented May 27, 2017

I recommend removing the "pi" prefix from the Actions, that was added under #30. Or, pick a different prefix.

How about "computer"?
How about making it configurable? We call ours "spee", so "spee power off" would work pretty well.


Per PR #30 , the new "power off" and "reboot" commands were prefixed with "pi":

"pi power off"
"pi reboot"

Unfortunately, our Voice Kit cannot interrupt "pi" most of the time. Cases in point:

5 year old daughter: "pi power off"
May 27 06:38:36 spee python3[550]: {'text': 'hey power off'}

me saying "pi power off"
May 27 06:38:51 spee python3[550]: {'text': 'hi power off'}

spouse saying "pi power off"
May 27 06:39:52 spee python3[550]: {'text': 'say power off'}

Only after about a dozen times, was "Pi power off" detected by me saying it.

Also, if you actually say commands like "hey power off", the assistant responds with "Sorry, Power commands are not yet supported."

^- this would indicate that the SDK may support power commands in the future itself through some API. Something to keep an eye out for.

@eduncan911

This comment has been minimized.

Show comment
Hide comment
@eduncan911

eduncan911 May 27, 2017

@ktinkerer tagging ya here.

I can change it as well.

Just, let's discuss here and figure out what to use (or make it configurable).

eduncan911 commented May 27, 2017

@ktinkerer tagging ya here.

I can change it as well.

Just, let's discuss here and figure out what to use (or make it configurable).

@ensonic

This comment has been minimized.

Show comment
Hide comment
@ensonic

ensonic May 30, 2017

Collaborator

What about making it 'Raspberry power off' (and reboot likewise) or 'cube power off'?

Collaborator

ensonic commented May 30, 2017

What about making it 'Raspberry power off' (and reboot likewise) or 'cube power off'?

@eduncan911

This comment has been minimized.

Show comment
Hide comment
@eduncan911

eduncan911 May 30, 2017

I think a configuration option, allowing the user to specify whatever prefix they like, would be best.

Or in my case, no prefix. "Hey Google, reboot" Because I use the hot words and it doesn't make sense to say, "Hey Google, Pi reboot"

Again I'm happy to do the work in a PR. Just want some feedback/discussion here first.


I like the infrastructure that was done as part of the original PR to enable this. It allows you to set up your own commands going forward. So if you want to add things like:

Turn Left
Power Off TV
Where's the space station tonight?

If you had a custom prefix, and set to say Computer, you could do:

<Trigger Action> Computer Turn Left
<Trigger Action> Computer Power Off TV
<Trigger Action> Computer Where's the space station tonight?

Which would work pretty good, because Computer is a complex word to match. being whatever you have setup: button push, clap, hot words, etc.

It's just I have Hot Word activation enabled on ours, which wouldn't make sense:

Hey Google <pause> Computer Turn Left
Hey Google <pause> Computer Power Off TV
Hey Google <pause> Computer Where's the space station tonight?

Confuses my 5 year old when I tried linking our GoPiGo over the weekend. "But that doesn't make sense" she said. lol

eduncan911 commented May 30, 2017

I think a configuration option, allowing the user to specify whatever prefix they like, would be best.

Or in my case, no prefix. "Hey Google, reboot" Because I use the hot words and it doesn't make sense to say, "Hey Google, Pi reboot"

Again I'm happy to do the work in a PR. Just want some feedback/discussion here first.


I like the infrastructure that was done as part of the original PR to enable this. It allows you to set up your own commands going forward. So if you want to add things like:

Turn Left
Power Off TV
Where's the space station tonight?

If you had a custom prefix, and set to say Computer, you could do:

<Trigger Action> Computer Turn Left
<Trigger Action> Computer Power Off TV
<Trigger Action> Computer Where's the space station tonight?

Which would work pretty good, because Computer is a complex word to match. being whatever you have setup: button push, clap, hot words, etc.

It's just I have Hot Word activation enabled on ours, which wouldn't make sense:

Hey Google <pause> Computer Turn Left
Hey Google <pause> Computer Power Off TV
Hey Google <pause> Computer Where's the space station tonight?

Confuses my 5 year old when I tried linking our GoPiGo over the weekend. "But that doesn't make sense" she said. lol

@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 30, 2017

Contributor

You can change the keywords in action.py to whatever you want:

actor.add_keyword(_('pi power off'), PowerCommand(say, 'shutdown'))
actor.add_keyword(_('pi reboot'), PowerCommand(say, 'reboot'))
Contributor

ktinkerer commented May 30, 2017

You can change the keywords in action.py to whatever you want:

actor.add_keyword(_('pi power off'), PowerCommand(say, 'shutdown'))
actor.add_keyword(_('pi reboot'), PowerCommand(say, 'reboot'))
@eduncan911

This comment has been minimized.

Show comment
Hide comment
@eduncan911

eduncan911 May 30, 2017

the point of this Issue is to change it to something from that default, as it does not work very well.. with now 5 different people trying it (see OP).

eduncan911 commented May 30, 2017

the point of this Issue is to change it to something from that default, as it does not work very well.. with now 5 different people trying it (see OP).

drigz added a commit to drigz/aiyprojects-raspbian that referenced this issue May 31, 2017

Use "raspberry" instead of "pi" as power keyword
The speech recognition wasn't very good at recognizing "pi" but
"raspberry" seems to work better.

Fixes #69.

@drigz drigz closed this in #73 May 31, 2017

drigz added a commit that referenced this issue May 31, 2017

Use "raspberry" instead of "pi" as power keyword (#73)
The speech recognition wasn't very good at recognizing "pi" but
"raspberry" seems to work better.

Fixes #69.
@holten

This comment has been minimized.

Show comment
Hide comment
@holten

holten Jun 3, 2017

My take was "sudo power off" and "sudo reboot". =)

holten commented Jun 3, 2017

My take was "sudo power off" and "sudo reboot". =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment