Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
"pi" actions are not interrupted #69
I recommend removing the "pi" prefix from the Actions, that was added under #30. Or, pick a different prefix.
How about "computer"?
Per PR #30 , the new "power off" and "reboot" commands were prefixed with "pi":
"pi power off"
Unfortunately, our Voice Kit cannot interrupt "pi" most of the time. Cases in point:
5 year old daughter: "pi power off"
me saying "pi power off"
spouse saying "pi power off"
Only after about a dozen times, was "Pi power off" detected by me saying it.
Also, if you actually say commands like "hey power off", the assistant responds with "Sorry, Power commands are not yet supported."
^- this would indicate that the SDK may support power commands in the future itself through some API. Something to keep an eye out for.
I think a configuration option, allowing the user to specify whatever prefix they like, would be best.
Or in my case, no prefix. "Hey Google, reboot" Because I use the hot words and it doesn't make sense to say, "Hey Google, Pi reboot"
Again I'm happy to do the work in a PR. Just want some feedback/discussion here first.
I like the infrastructure that was done as part of the original PR to enable this. It allows you to set up your own commands going forward. So if you want to add things like:
If you had a custom prefix, and set to say Computer, you could do:
Which would work pretty good, because Computer is a complex word to match. being whatever you have setup: button push, clap, hot words, etc.
It's just I have Hot Word activation enabled on ours, which wouldn't make sense:
Confuses my 5 year old when I tried linking our GoPiGo over the weekend. "But that doesn't make sense" she said. lol