New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shutdown and reboot commands #30

Merged
merged 2 commits into from May 24, 2017

Conversation

Projects
None yet
6 participants
@ktinkerer
Contributor

ktinkerer commented May 11, 2017

Adds commands to shutdown and reboot the pi.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 11, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented May 11, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label May 11, 2017

@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 11, 2017

Contributor

I signed it

Contributor

ktinkerer commented May 11, 2017

I signed it

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 11, 2017

CLAs look good, thanks!

googlebot commented May 11, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 11, 2017

Show outdated Hide outdated src/action.py
Show outdated Hide outdated src/action.py
@ensonic

This comment has been minimized.

Show comment
Hide comment
@ensonic

ensonic May 15, 2017

Collaborator

Hi, please make sure travis is happy with your PR. Follow the Details link above to see a report. Also please don't add extra change to this PR if they are belonging to a different feature (radio support).

Collaborator

ensonic commented May 15, 2017

Hi, please make sure travis is happy with your PR. Follow the Details link above to see a report. Also please don't add extra change to this PR if they are belonging to a different feature (radio support).

@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 15, 2017

Contributor

Sorry that was my Github mess up, not realising it would interfere with this PR, I've removed all those changes, they were the ones causing the error.

Contributor

ktinkerer commented May 15, 2017

Sorry that was my Github mess up, not realising it would interfere with this PR, I've removed all those changes, they were the ones causing the error.

@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 17, 2017

Contributor

Do I need to git reset to remove those extra commits? Wanted to check before I make more of a mess of it?

Contributor

ktinkerer commented May 17, 2017

Do I need to git reset to remove those extra commits? Wanted to check before I make more of a mess of it?

@ensonic

This comment has been minimized.

Show comment
Hide comment
@ensonic

ensonic May 17, 2017

Collaborator

There are many ways. Just to make sure you don't loose anything I'd recommend to do

git format-patch origin

This will save a patch file for each commit. Now you can do

git rebase -i origin

and delete the lines of the commits that we don't have. Once the PR is merged you can

git am xxx.patch

to apply them again.

Collaborator

ensonic commented May 17, 2017

There are many ways. Just to make sure you don't loose anything I'd recommend to do

git format-patch origin

This will save a patch file for each commit. Now you can do

git rebase -i origin

and delete the lines of the commits that we don't have. Once the PR is merged you can

git am xxx.patch

to apply them again.

@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 17, 2017

Contributor

Thank you for your help, I think I've got there in the end, I will learn git eventually! But travis still shows an error?

Contributor

ktinkerer commented May 17, 2017

Thank you for your help, I think I've got there in the end, I will learn git eventually! But travis still shows an error?

@ensonic

This comment has been minimized.

Show comment
Hide comment
@ensonic

ensonic May 17, 2017

Collaborator

Yep, still there:
https://travis-ci.org/google/aiyprojects-raspbian/builds/233372818#L172

You can run the check locally:

pep8 --max-line-length=100 .
Collaborator

ensonic commented May 17, 2017

Yep, still there:
https://travis-ci.org/google/aiyprojects-raspbian/builds/233372818#L172

You can run the check locally:

pep8 --max-line-length=100 .
@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 18, 2017

Contributor

Thanks for that tip, missing blank line, passes now.

Contributor

ktinkerer commented May 18, 2017

Thanks for that tip, missing blank line, passes now.

@ensonic

This comment has been minimized.

Show comment
Hide comment
@ensonic

ensonic May 24, 2017

Collaborator

@ktinkerer can you please rebase the PR and make the commands 'pi power off' and 'pi reboot'. Then we can merge it.

Collaborator

ensonic commented May 24, 2017

@ktinkerer can you please rebase the PR and make the commands 'pi power off' and 'pi reboot'. Then we can merge it.

ktinkerer added some commits May 11, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io May 24, 2017

Codecov Report

Merging #30 into master will increase coverage by 0.09%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
+ Coverage    9.67%   9.76%   +0.09%     
=========================================
  Files           3       3              
  Lines        1705    1720      +15     
  Branches      293     295       +2     
=========================================
+ Hits          165     168       +3     
- Misses       1530    1542      +12     
  Partials       10      10
Impacted Files Coverage Δ
src/action.py 60% <20%> (-5.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9571936...77ebd68. Read the comment docs.

codecov-io commented May 24, 2017

Codecov Report

Merging #30 into master will increase coverage by 0.09%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
+ Coverage    9.67%   9.76%   +0.09%     
=========================================
  Files           3       3              
  Lines        1705    1720      +15     
  Branches      293     295       +2     
=========================================
+ Hits          165     168       +3     
- Misses       1530    1542      +12     
  Partials       10      10
Impacted Files Coverage Δ
src/action.py 60% <20%> (-5.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9571936...77ebd68. Read the comment docs.

@ktinkerer

This comment has been minimized.

Show comment
Hide comment
@ktinkerer

ktinkerer May 24, 2017

Contributor

Is that right?

Contributor

ktinkerer commented May 24, 2017

Is that right?

@drigz drigz merged commit 250b8cb into google:master May 24, 2017

4 checks passed

cla/google All necessary CLAs are signed
codecov/patch 20% of diff hit (target 9.67%)
Details
codecov/project 9.76% (+0.09%) compared to 9571936
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@drigz

This comment has been minimized.

Show comment
Hide comment
@drigz

drigz May 24, 2017

Member

Looks great, thanks for working on it!

Member

drigz commented May 24, 2017

Looks great, thanks for working on it!

Rexypoo added a commit to Rexypoo/aiyprojects-raspbian that referenced this pull request Jun 1, 2017

Added shutdown and reboot commands (google#30)
* Added shutdown and reboot commands

* added pi to the keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment