Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom style attributes #633

Merged
merged 49 commits into from Dec 28, 2021
Merged

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented Jul 6, 2021

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #501 (GSOC Project)

Description
Create default style for the views in Data Capture Library then override it in SDC Gallery and change it with our own custom style.

Alternative(s) considered
N.A

Type
Choose one: Feature

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@FikriMilano FikriMilano changed the title Add custom style for Group Header questionnaire Create example of custom style in SDC Gallery Jul 6, 2021
@FikriMilano FikriMilano changed the title Create example of custom style in SDC Gallery Create examples of custom style in SDC Gallery Jul 6, 2021
@FikriMilano FikriMilano changed the title Create examples of custom style in SDC Gallery [WIP]: Create examples of custom style in SDC Gallery Jul 6, 2021
@google-cla
Copy link

google-cla bot commented Jul 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jul 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me, just left few comments.
Thanks!

@FikriMilano
Copy link
Collaborator Author

@santosh-pingle could you review this again? thanks

…into fm/custom-style

� Conflicts:
�	datacapture/src/main/res/layout/questionnaire_item_drop_down_view.xml
@santosh-pingle
Copy link
Collaborator

LGTM

@qiarie
Copy link
Collaborator

qiarie commented Nov 11, 2021

@FikriMilano Please merge latest changes in master

@FikriMilano
Copy link
Collaborator Author

Could someone give me some insight on how to test this? because a huge part of the changes are from xml

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I was testing this and couldn't get thing to work... and then realised that in values-night/themes.xml the theme override isn't set.... can you please add this to the that file similar to value/themes.xml:
        <!-- Customize theme for questionnaires in this application. -->
        <item name="questionnaire_theme">@style/Theme.MyQuestionnaire</item>
  1. Please rename the PR name to something like Add custom style attributes
  2. I think the most critical part of this PR is that you're adding the custom style attributes, I don't feel it's necessarily that useful to provide an example for each one in the datacapturegallary app - I think you can simplify that file, having one or two examples is enough, especially no need to override the tint effect for radio buttons.

@FikriMilano FikriMilano changed the title Create examples of custom style in SDC Gallery Add custom style attributes Nov 24, 2021
@FikriMilano
Copy link
Collaborator Author

Alright, thanks for the feedback

@jingtang10 jingtang10 enabled auto-merge (squash) December 28, 2021 10:58
@jingtang10 jingtang10 merged commit 881acf2 into google:master Dec 28, 2021
Demo applications automation moved this from In progress to Done Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create examples of custom style in the sdc gallery application
7 participants