New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom style attributes #633
Conversation
fd5a0a2
to
579ae41
Compare
817a6da
to
7922740
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
77f0953
to
3fc39b9
Compare
…into fm/custom-style
datacapture/src/main/res/layout/questionnaire_item_checkbox_group_view.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok to me, just left few comments.
Thanks!
@santosh-pingle could you review this again? thanks |
…into fm/custom-style � Conflicts: � datacapture/src/main/res/layout/questionnaire_item_drop_down_view.xml
LGTM |
@FikriMilano Please merge latest changes in master |
…into fm/custom-style
…into fm/custom-style
Could someone give me some insight on how to test this? because a huge part of the changes are from xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I was testing this and couldn't get thing to work... and then realised that in
values-night/themes.xml
the theme override isn't set.... can you please add this to the that file similar tovalue/themes.xml
:
<!-- Customize theme for questionnaires in this application. -->
<item name="questionnaire_theme">@style/Theme.MyQuestionnaire</item>
- Please rename the PR name to something like
Add custom style attributes
- I think the most critical part of this PR is that you're adding the custom style attributes, I don't feel it's necessarily that useful to provide an example for each one in the datacapturegallary app - I think you can simplify that file, having one or two examples is enough, especially no need to override the tint effect for radio buttons.
Alright, thanks for the feedback |
…into fm/custom-style
…into fm/custom-style
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #501 (GSOC Project)
Description
Create default style for the views in Data Capture Library then override it in SDC Gallery and change it with our own custom style.
Alternative(s) considered
N.A
Type
Choose one: Feature
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project./gradlew check
and./gradlew connectedCheck
to test my changes locally