Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dynamic commands and bump version #132

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

sadmac7000
Copy link
Collaborator

No description provided.

Copy link
Contributor

@richkadel richkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits regarding my preference for 80 character columns, but the main thing is, I think the trait functions and/or the example code, or both, need additional explanation, because it's hard to follow the advanced (and uncommonly used) constructs of multiple static lifetimes, and Box::leak(). I can take another look this weekend if you want to follow up, or next week.

argh/src/lib.rs Outdated Show resolved Hide resolved
argh/src/lib.rs Outdated Show resolved Hide resolved
argh/src/lib.rs Show resolved Hide resolved
argh/src/lib.rs Show resolved Hide resolved
Copy link
Contributor

@richkadel richkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@sadmac7000 sadmac7000 merged commit b9296f0 into google:master Jun 26, 2022
@sadmac7000 sadmac7000 deleted the master branch November 4, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants