From 5beb73ab575fbea6303402c4e9bcfdc7043352fe Mon Sep 17 00:00:00 2001
From: ronshapiro <ronshapiro@google.com>
Date: Tue, 12 Mar 2019 10:02:53 -0700
Subject: [PATCH] Remove checkstyle references. It's unclear when the last time
 this was relevant, but we seem to be ignoring it now anyway.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=238038517
---
 CONTRIBUTING.md |  14 ++---
 checkstyle.xml  | 136 ------------------------------------------------
 pom.xml         |  10 ----
 3 files changed, 4 insertions(+), 156 deletions(-)
 delete mode 100644 checkstyle.xml

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 1efdd026d9..b5622f6f7a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -5,18 +5,18 @@ If you would like to contribute code to Auto you can do so through GitHub
 by forking the repository and sending a pull request.
 
 When submitting code, please make every effort to follow existing conventions
-and style in order to keep the code as readable as possible.  
+and style in order to keep the code as readable as possible.
 
 Where appropriate, please provide unit tests or integration tests. Unit tests
 should be JUnit based tests and can use either standard JUnit assertions or
-Truth assertions and be added to `<project>/src/test/java`.  Changes to 
-code generation or other build-time behaviour should go into small maven 
+Truth assertions and be added to `<project>/src/test/java`.  Changes to
+code generation or other build-time behaviour should go into small maven
 projects using the `maven-invoker-plugin`.  Examples of this are in
 `generator/src/it` and can include bean-shell verification scripts and other
 facilities provided by `maven-invoker-plugin`.
 
 Please make sure your code compiles by running `mvn clean verify` which will
-execute both unit and integration test phases.  Additionally, consider using 
+execute both unit and integration test phases.  Additionally, consider using
 http://travis-ci.org to validate your branches before you even put them into
 pull requests.  All pull requests will be validated by Travis-ci in any case
 and must pass before being merged.
@@ -27,12 +27,6 @@ note that a Google, Inc. copyright line must appear in every copyright notice.
 All files are released with the Apache 2.0 license and any new files may only
 be accepted under the terms of that license.
 
-Checkstyle failures during compilation indicate errors in your style and will
-be displayed in the console output of the build (including in Travis-CI output),
-or can be viewed in the `checkstyle-result.xml` file.  To save yourself some
-hassle, consider executing checkstyle first per: 'mvn checkstyle:checkstyle'.
-It's fast, and will catch style errors early.
-
 Before your code can be accepted into the project you must sign the
 [Individual Contributor License Agreement (CLA)][1].
 
diff --git a/checkstyle.xml b/checkstyle.xml
deleted file mode 100644
index 24eeebef9e..0000000000
--- a/checkstyle.xml
+++ /dev/null
@@ -1,136 +0,0 @@
-<?xml version="1.0"?>
-<!DOCTYPE module PUBLIC
-    "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
-    "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
-
-<module name="Checker">
-    <!--module name="NewlineAtEndOfFile"/-->
-    <module name="FileLength"/>
-    <module name="FileTabCharacter"/>
-
-    <!-- Space after 'for' and 'if' -->
-    <module name="RegexpSingleline">
-        <property name="format" value="^\s*(for|if)[^ ]"/>
-        <property name="message" value="Space needed before opening parenthesis."/>
-    </module>
-
-    <!-- For each spacing -->
-    <module name="RegexpSingleline">
-        <property name="format" value="^\s*for \(.*?([^ ]:|:[^ ])"/>
-        <property name="message" value="Space needed around ':' character."/>
-    </module>
-
-    <module name="TreeWalker">
-        <property name="cacheFile" value="${checkstyle.cache.file}"/>
-
-        <!-- Checks for Javadoc comments.                     -->
-        <!-- See http://checkstyle.sf.net/config_javadoc.html -->
-        <!--module name="JavadocMethod"/-->
-        <!--module name="JavadocType"/-->
-        <!--module name="JavadocVariable"/-->
-        <!--module name="JavadocStyle"/-->
-
-
-        <!-- Checks for Naming Conventions.                  -->
-        <!-- See http://checkstyle.sf.net/config_naming.html -->
-        <!--<module name="ConstantName"/>-->
-        <module name="LocalFinalVariableName"/>
-        <module name="LocalVariableName"/>
-        <module name="MemberName"/>
-        <module name="MethodName"/>
-        <module name="PackageName"/>
-        <module name="ParameterName"/>
-        <module name="StaticVariableName"/>
-        <module name="TypeName"/>
-
-
-        <!-- Checks for imports                               -->
-        <!-- See http://checkstyle.sf.net/config_imports.html -->
-        <module name="AvoidStarImport"/>
-        <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
-        <module name="RedundantImport"/>
-        <module name="UnusedImports">
-            <property name="processJavadoc" value="true"/>
-        </module>
-
-
-        <!-- Checks for Size Violations.                    -->
-        <!-- See http://checkstyle.sf.net/config_sizes.html -->
-        <module name="LineLength">
-            <property name="max" value="100"/>
-        </module>
-        <module name="MethodLength"/>
-        <!--module name="ParameterNumber"/-->
-
-
-        <!-- Checks for whitespace                               -->
-        <!-- See http://checkstyle.sf.net/config_whitespace.html -->
-        <module name="GenericWhitespace"/>
-        <module name="EmptyForIteratorPad"/>
-        <module name="MethodParamPad"/>
-        <module name="NoWhitespaceAfter"/>
-        <module name="NoWhitespaceBefore"/>
-        <module name="OperatorWrap"/>
-        <module name="ParenPad"/>
-        <module name="TypecastParenPad"/>
-        <module name="WhitespaceAfter"/>
-        <module name="WhitespaceAround">
-          <property name="allowEmptyConstructors" value="true"/>
-          <property name="allowEmptyMethods" value="true"/>
-        </module>
-
-
-        <!-- Modifier Checks                                   -->
-        <!-- See http://checkstyle.sf.net/config_modifier.html -->
-        <!--module name="ModifierOrder"/-->
-        <module name="RedundantModifier"/>
-
-
-        <!-- Checks for blocks. You know, those {}'s         -->
-        <!-- See http://checkstyle.sf.net/config_blocks.html -->
-        <!--module name="AvoidNestedBlocks"/-->
-        <!--module name="EmptyBlock"/-->
-        <module name="LeftCurly"/>
-        <!--module name="NeedBraces"/-->
-        <module name="RightCurly"/>
-
-
-        <!-- Checks for common coding problems               -->
-        <!-- See http://checkstyle.sf.net/config_coding.html -->
-        <!--module name="AvoidInlineConditionals"/-->
-        <module name="CovariantEquals"/>
-        <module name="EmptyStatement"/>
-        <!--<module name="EqualsAvoidNull"/>-->
-        <module name="EqualsHashCode"/>
-        <!--module name="HiddenField"/-->
-        <module name="IllegalInstantiation"/>
-        <!--<module name="InnerAssignment"/>-->
-        <!--module name="MagicNumber"/-->
-        <!-- <module name="MissingSwitchDefault"/> -->
-        <module name="RedundantThrows"/>
-        <module name="SimplifyBooleanExpression"/>
-        <module name="SimplifyBooleanReturn"/>
-
-        <!-- Checks for class design                         -->
-        <!-- See http://checkstyle.sf.net/config_design.html -->
-        <!--module name="DesignForExtension"/-->
-        <!--module name="FinalClass"/-->
-        <!--module name="HideUtilityClassConstructor"/-->
-        <!--module name="InterfaceIsType"/-->
-        <!--module name="VisibilityModifier"/-->
-
-
-        <!-- Miscellaneous other checks.                   -->
-        <!-- See http://checkstyle.sf.net/config_misc.html -->
-        <!--module name="ArrayTypeStyle"/-->
-        <!--module name="FinalParameters"/-->
-        <!--module name="TodoComment"/-->
-        <module name="UpperEll"/>
-        
-        <!-- Enable suppression later -->
-        <module name="FileContentsHolder"/>
-    </module>
-    
-    <!-- Allow suppression via comments -->
-    <module name="SuppressionCommentFilter"/>
-</module>
diff --git a/pom.xml b/pom.xml
index b90bf7f7a4..d8df376d6b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -154,16 +154,6 @@
             </dependency>
           </dependencies>
         </plugin>
-        <plugin>
-          <groupId>org.apache.maven.plugins</groupId>
-          <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.17</version>
-          <configuration>
-            <consoleOutput>true</consoleOutput>
-            <configLocation>checkstyle.xml</configLocation>
-            <failOnViolation>false</failOnViolation>
-          </configuration>
-        </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-jar-plugin</artifactId>