Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help popular auto value extensions adopt incremental processing #673

Closed
7 tasks done
bingranl opened this issue Oct 29, 2018 · 12 comments
Closed
7 tasks done

Help popular auto value extensions adopt incremental processing #673

bingranl opened this issue Oct 29, 2018 · 12 comments

Comments

@bingranl
Copy link

bingranl commented Oct 29, 2018

@bingranl bingranl changed the title Help popular auto value extension adopt incremental processing Help popular auto value extensions adopt incremental processing Oct 29, 2018
@autonomousapps
Copy link

autonomousapps commented Oct 29, 2018

Here's an associated issue on gradle/gradle: gradle/gradle#5277

@tbroyer
Copy link
Contributor

tbroyer commented Oct 29, 2018

Fwiw, autovalue extensions are not processors themselves. There's a new API in 1.6.3rc1 to be implemented by extensions: http://static.javadoc.io/com.google.auto.value/auto-value-annotations/1.6.3rc1/com/google/auto/value/extension/AutoValueExtension.html#incrementalType-javax.annotation.processing.ProcessingEnvironment-

@bingranl
Copy link
Author

bingranl commented Oct 29, 2018

Yeah, our goal is to let extensions figure out if they are compatible with incremental processing and implement that new API.

@gabrielittner
Copy link

gabrielittner commented Oct 29, 2018

I'll look into my two extensions later this week (with and cursor).

@tbroyer
Copy link
Contributor

tbroyer commented Oct 29, 2018

I meant: the open issues linked above (auto-value-gson and auto-value-gson) don't talk about the AutoValueExtension API, they only link to Gradle's documentation.

@gabrielittner
Copy link

gabrielittner commented Nov 4, 2018

auto-value-with 1.1.0-rc1 and auto-value-cursor 2.0.0-rc1 are on their way to maven central. Both are ISOLATING.

@bingranl
Copy link
Author

bingranl commented Nov 5, 2018

@gabrielittner Great, thanks!!

@ZacSweers
Copy link
Contributor

ZacSweers commented Nov 17, 2018

auto-value-gson, auto-value-moshi, and auto-value-parcel all support this now (extensions are ISOLATING and the factory processors are AGGREGATING), and will be in their next releases

@bingranl
Copy link
Author

bingranl commented Feb 12, 2019

auto-value-redacted is ISOLATING now. auto-value-bundle is removed from the list since it is not released.

@emartynov
Copy link

emartynov commented May 28, 2019

People, what about AutoFactory?

@bejibx
Copy link

bejibx commented Jun 17, 2019

PaperParcel supports incap since 2.0.7, see changelog.

@bingranl
Copy link
Author

bingranl commented Jun 17, 2019

@bejibx Thanks for great work! I am closing this issue because all of the popular auto value extensions support incremental annotation processing! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants