New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build is not ready #7

Closed
syoyo opened this Issue Feb 5, 2014 · 6 comments

Comments

Projects
None yet
6 participants
@syoyo

syoyo commented Feb 5, 2014

Some part of code is Windows-aware(ifdef'ed with OS_WINDOWS), but still incomplete(e.g. pthread.h in benchmark.h)

@dominichamon dominichamon self-assigned this Feb 5, 2014

@pleroy

This comment has been minimized.

Show comment
Hide comment
@pleroy

pleroy May 29, 2014

Member

FWIW I have a port for Windows based on the pthread library at http://locklessinc.com/downloads/ (BSD 3-clause). Not quite ready for a pull request, but getting there.

Member

pleroy commented May 29, 2014

FWIW I have a port for Windows based on the pthread library at http://locklessinc.com/downloads/ (BSD 3-clause). Not quite ready for a pull request, but getting there.

@dominichamon

This comment has been minimized.

Show comment
Hide comment
@dominichamon

dominichamon Mar 31, 2015

Member

#64 has landed which gives us a working mingw port. does that help?

Member

dominichamon commented Mar 31, 2015

#64 has landed which gives us a working mingw port. does that help?

@mattyclarkson

This comment has been minimized.

Show comment
Hide comment
@mattyclarkson

mattyclarkson Mar 31, 2015

Contributor

@dominichamon, I tried having a go at getting VS2013 up and going but there are a few things missing with the C++11 support. I'll just brain dump here in case anyone can pick it up:

  • gettimeofday needs to be polyfilled in walltime.cc
  • (gm|local)time_r needs to be changed for (gm|local)time_s. arguments to swap over.
  • constexpr support is sketchy so things don't compile
  • noexcept wasn't supported
  • CMakeList.txt needs if (MSVC) to avoid all the GCC/Clang flag checks (not an issue as they fail gracefully, just looks weird)
  • By default cmake adds /Wall which turns on warnings that even the STL that is shipped with Visual Studio doesn't compile with. I'd suggest starting with /W0 and slowly cranking that up to /W4 putting the necessary /wdXXXX in the CMakeList.txt or the pragma warning() around the offending areas. It would be great to have a clean MSVC build at high warning levels as it might catch things that GCC/Clang might miss

It's almost there, just needs a bit of love. cmake -G "Visual Studio 12 2013" gets things going.

Once the Visual Studio build is going the appveyor support to continuously check for MSVC support can be added by implementing msbuild like cppformat does here. Will just have to add the necessary lines to appveyor.yml when if "%compiler_name%"=="msvc".

Contributor

mattyclarkson commented Mar 31, 2015

@dominichamon, I tried having a go at getting VS2013 up and going but there are a few things missing with the C++11 support. I'll just brain dump here in case anyone can pick it up:

  • gettimeofday needs to be polyfilled in walltime.cc
  • (gm|local)time_r needs to be changed for (gm|local)time_s. arguments to swap over.
  • constexpr support is sketchy so things don't compile
  • noexcept wasn't supported
  • CMakeList.txt needs if (MSVC) to avoid all the GCC/Clang flag checks (not an issue as they fail gracefully, just looks weird)
  • By default cmake adds /Wall which turns on warnings that even the STL that is shipped with Visual Studio doesn't compile with. I'd suggest starting with /W0 and slowly cranking that up to /W4 putting the necessary /wdXXXX in the CMakeList.txt or the pragma warning() around the offending areas. It would be great to have a clean MSVC build at high warning levels as it might catch things that GCC/Clang might miss

It's almost there, just needs a bit of love. cmake -G "Visual Studio 12 2013" gets things going.

Once the Visual Studio build is going the appveyor support to continuously check for MSVC support can be added by implementing msbuild like cppformat does here. Will just have to add the necessary lines to appveyor.yml when if "%compiler_name%"=="msvc".

@KindDragon

This comment has been minimized.

Show comment
Hide comment
@KindDragon

KindDragon Feb 9, 2016

Contributor

Relate to PR #175

Contributor

KindDragon commented Feb 9, 2016

Relate to PR #175

@EricWF

This comment has been minimized.

Show comment
Hide comment
@EricWF

EricWF Aug 29, 2016

Collaborator

Closing since the Windows build seems to be working and Appveyor is testing it on every commit.

Collaborator

EricWF commented Aug 29, 2016

Closing since the Windows build seems to be working and Appveyor is testing it on every commit.

@EricWF EricWF closed this Aug 29, 2016

@syoyo

This comment has been minimized.

Show comment
Hide comment
@syoyo

syoyo Aug 29, 2016

Super cool! Thank you!

syoyo commented Aug 29, 2016

Super cool! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment