Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass on 1-core VMs #653

Merged
merged 1 commit into from Aug 28, 2018
Merged

Make tests pass on 1-core VMs #653

merged 1 commit into from Aug 28, 2018

Conversation

bmwiedemann
Copy link
Contributor

found while working on reproducible builds for openSUSE

To reproduce there
osc checkout openSUSE:Factory/benchmark && cd $_
osc build -j1 --vm-type=kvm

found while working on reproducible builds for openSUSE

To reproduce there
osc checkout openSUSE:Factory/benchmark && cd $_
osc build -j1 --vm-type=kvm
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.877% when pulling 7c917eb on bmwiedemann:j1 into af441fc on google:master.

@AppVeyorBot
Copy link

Copy link
Collaborator

@LebedevRI LebedevRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but do we want to actually check that we print s only when there is just one cpu?

@bmwiedemann
Copy link
Contributor Author

I don't care. I could even live with a program telling me that I have "1 CPUs". Keeping code simple is always a plus for future maintainability.

Copy link
Collaborator

@LebedevRI LebedevRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LG to me. I, too, don't think that s matters much.
If no one else has an opinion i'll merge next week.

@dmah42
Copy link
Member

dmah42 commented Aug 28, 2018

LGTM

@LebedevRI LebedevRI merged commit ede90ba into google:master Aug 28, 2018
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Dec 6, 2018
found while working on reproducible builds for openSUSE

To reproduce there
osc checkout openSUSE:Factory/benchmark && cd $_
osc build -j1 --vm-type=kvm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants