Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
in build.py self.do_compile (line 274) not returning valid JSON #1399
As of last night, build.py began failing with the following error:
What were you trying to do when you hit this bug? Or, what do you want to do with Blockly that your proposed feature would enable?
Trying to compile into compressed files by running build.py
Please describe what should happen. Include screenshots if applicable.
build.py should complete with no errors.
Describe what actually happens. Include screenshots if applicable.
When I run sudo python build.py many modules compile. Right after /msg/js/zh-hant.js, I get the error pasted above.
Explain what someone needs to do in order to see what's described in Actual behavior above
Operating System and Browser
-[x] Terminal window OS X
Anything else we should know?
Here are the relevant lines (264-74) in my build.py. Looks like I am a few revs behind, but if something changed on Google's side, is there a way to provide some backward compatibility, so that I don't have to update blockly immediately?
Unpeeled the onion by a couple of layers. 'develop' appeared to be working because for some reason someone reconfigured it to either build compressed files xor build the demo files. When the demo build was removed, this accidentally started xoring the build against accessible files instead.
PR #1401 fixes this issue, thus breaking 'develop' to match 'master'. This PR also reveals that the online Closure Compiler is returning a blank response for all eight compression operations. Looks like the online Closure Compiler is just having a bad day, but I'll still investigating...