feat(tests): Use official semver.org RegExp #5990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the official semantic versioning regexp from https://semver.org/, rather than the shorter but sloppier one we had previously found at https://gist.github.com/jhorsman/62eeea161a13b80e39f5249281e17c39.
BeksOmega
approved these changes
Mar 9, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Use the official semantic versioning regexp from semver.org rather than the shorter but sloppier one
we had previously found.
Reason for Changes
Avoid any possible problems that could be caused by invalid version numbers in
renamings.json5when comparing version numbers in the process of running the renamings script.Test Coverage
npm test.