Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee that the top and bottom rows exist #2852

Merged
merged 1 commit into from Aug 17, 2019
Merged

Guarantee that the top and bottom rows exist #2852

merged 1 commit into from Aug 17, 2019

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

Creates that top and bottom rows immediately, so that they can be annotated non-null.

alschmiedt
alschmiedt approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@alschmiedt alschmiedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rachel-fenichel rachel-fenichel merged commit 64a5da9 into google:develop Aug 17, 2019
@rachel-fenichel rachel-fenichel deleted the populate_rows branch August 17, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alschmiedt alschmiedt alschmiedt approved these changes

Assignees

@alschmiedt alschmiedt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rachel-fenichel @alschmiedt