-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect blockchange firing #7492
fix: incorrect blockchange firing #7492
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello @BeksOmega , can you check, i've disabled the BlockChange event and verified it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
-
You can find tips about contributing to Blockly and how to
validate your changes on our
developer site. -
All contributors must sign the Google Contributor License
Agreement (CLA). If the google-cla bot leaves a comment on this
PR, make sure you follow the instructions. -
We use conventional commits
to make versioning the package easier. Make sure your commit
message is in the proper format
or learn how to fix it. -
If any of the other checks on this PR fail, you can click on
them to learn why. It might be that your change caused a test
failure, or that you need to double-check the
style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
Hello @devbysn I still need to manually test, but this change LGTM =) Can you sign the CLA so I can get this merged? Thank you for your work on this! |
Hey @BeksOmega , i've signed the CLA. but idk why some tests are failing. can you guide? |
Hiya @devbysn You need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually verified this change looks good.
I've done the |
This looks great @devbysn :D Thank you so much for your contribution! If you'd like to continue contributing let me know and I can recommend something! Or you can pick whatever you find interesting out of the backlog =) |
The basics
The details
Resolves
Fixes : #7448
Proposed Changes
Removes the unwanted BlockChange event during jsonInit.
Reason for Changes
disabling the event while creating will fix it.
Test Coverage
Documentation
Additional Information