Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect blockchange firing #7492

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

devbysn
Copy link
Contributor

@devbysn devbysn commented Sep 15, 2023

The basics

The details

Resolves

Fixes : #7448

Proposed Changes

Removes the unwanted BlockChange event during jsonInit.

Screenshot from 2023-09-15 11-09-45

Reason for Changes

    if (json['inputsInline'] !== undefined) {
      eventUtils.disable();
      this.setInputsInline(json['inputsInline']);
      eventUtils.enable();
    }

disabling the event while creating will fix it.

Test Coverage

Documentation

Additional Information

@devbysn devbysn requested a review from a team as a code owner September 15, 2023 05:42
@google-cla
Copy link

google-cla bot commented Sep 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@devbysn
Copy link
Contributor Author

devbysn commented Sep 15, 2023

Hello @BeksOmega ,

can you check, i've disabled the BlockChange event and verified it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to
    validate your changes on our
    developer site.

  • All contributors must sign the Google Contributor License
    Agreement (CLA). If the google-cla bot leaves a comment on this
    PR, make sure you follow the instructions.

  • We use conventional commits
    to make versioning the package easier. Make sure your commit
    message is in the proper format
    or learn how to fix it.

  • If any of the other checks on this PR fail, you can click on
    them to learn why. It might be that your change caused a test
    failure, or that you need to double-check the
    style guide.

Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega assigned BeksOmega and unassigned NeilFraser Sep 18, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for NeilFraser September 18, 2023 13:20
@BeksOmega BeksOmega changed the title Incorrect blockchange firing fix: incorrect blockchange firing Sep 18, 2023
@github-actions github-actions bot added the PR: fix Fixes a bug label Sep 18, 2023
@BeksOmega
Copy link
Collaborator

Hello @devbysn I still need to manually test, but this change LGTM =) Can you sign the CLA so I can get this merged? Thank you for your work on this!

@devbysn
Copy link
Contributor Author

devbysn commented Sep 20, 2023

Hey @BeksOmega ,

i've signed the CLA.

but idk why some tests are failing.

can you guide?
thanks :)

@BeksOmega
Copy link
Collaborator

BeksOmega commented Sep 20, 2023

Hiya @devbysn You need to run npm run format in the root blockly directory, and then commit those changes! After that this change should be good to go =)

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified this change looks good.

@devbysn
Copy link
Contributor Author

devbysn commented Sep 21, 2023

I've done thenpm run format, can you check now @BeksOmega ?

@BeksOmega
Copy link
Collaborator

This looks great @devbysn :D Thank you so much for your contribution! If you'd like to continue contributing let me know and I can recommend something! Or you can pick whatever you find interesting out of the backlog =)

@BeksOmega BeksOmega merged commit 4a6d439 into google:develop Sep 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setInputsInline fires an incorrect BlockChange event during jsonInit
3 participants