Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toFlyoutData method for compatibility with backpack #8002

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Work on google/blockly-samples#2311

Proposed Changes

Adds a toFlyoutData method to the BlockSvg so that we can add it to the backpack without knowing its exact type.

Test Coverage

Manually tested that the output looks correct (it's the same logic that currently exists in the backpack plugin). I can add unit tests, but kinda wanted this to go in the beta today.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from maribethb April 5, 2024 16:41
@BeksOmega BeksOmega requested a review from a team as a code owner April 5, 2024 16:41
@github-actions github-actions bot added the PR: feature Adds a feature label Apr 5, 2024
@maribethb maribethb merged commit e8c5196 into google:rc/v11.0.0 Apr 5, 2024
10 checks passed
johnnesky pushed a commit to johnnesky/blockly that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants