Fix missing symbols errors in libbrotlienc and dec #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using autotools to build the binary and libraries, the resulting libraries don't link `brotlicommon` or `m`. This was detected when building cURL 7.57.0 which has now has brotli support. During configure it was failing ``` checking run-time libs availability... failed configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lbrotlidec -lz -L/usr/local/lib ``` inspection of config.log showed missing symbols from libbrotlicommon as the cause. This patch results in the encryption and decryption libs to be properly linked against libbrotlicommon and libm. See also https://bugs.freebsd.org/223966
|
Thanks! |
juj
pushed a commit
to Unity-Technologies/brotli
that referenced
this pull request
May 13, 2023
When using autotools to build the binary and libraries, the resulting libraries don't link `brotlicommon` or `m`. This was detected when building cURL 7.57.0 which has now has brotli support. During configure it was failing ``` checking run-time libs availability... failed configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lbrotlidec -lz -L/usr/local/lib ``` inspection of config.log showed missing symbols from libbrotlicommon as the cause. This patch results in the encryption and decryption libs to be properly linked against libbrotlicommon and libm. See also https://bugs.freebsd.org/223966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using autotools to build the binary and libraries, the resulting libraries don't link
brotlicommonorm.This was detected when building cURL 7.57.0 which has now has brotli support. During configure it was failing
inspection of config.log showed missing symbols from libbrotlicommon as the cause.
This patch results in the encryption and decryption libs to be properly linked against libbrotlicommon and libm.
See also https://bugs.freebsd.org/223966