Skip to content

Conversation

@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Mar 7, 2019

Always collect disk stats for root.

Kubelet needs it for all runtimes.

@dashpole Can you help me double check whether this is sufficient for CRI runtimes?

Based on my understanding and testing, this seems sufficient.

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
Copy link
Member Author

/test pull-cadvisor-e2e

@dashpole
Copy link
Collaborator

dashpole commented Mar 7, 2019

container/common/container_hints_test.go:30:3: Errorf format %s has arg cHints of wrong type github.com/google/cadvisor/container/common.containerHints
container/common/container_hints_test.go:47:4: Errorf format %s has arg cHints of wrong type github.com/google/cadvisor/container/common.containerHints

I think maybe we updated the go version or something recently. Can you fix the go lint errors?

Your change looks correct, and should work for CRI runtimes.

Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu Random-Liu force-pushed the always-rootfs-disk-stats branch from 73831cd to 2522da0 Compare March 7, 2019 18:32
@Random-Liu
Copy link
Member Author

Fixed the test.

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 7e9ea00 into google:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants