Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the duration declarations in the new style when UTC is enabled #565



Copy link

Since the UTC fix is isolated to timestamps only the timestamp overloads were provided in the new style using Function; however, this causes a problem with dynamic dispatch where the functions like getHours are split between timestamps and durations. The generated dynamic dispatch function was then receiving the call instead of the Duration object resulting in a no such overload error.

This has been remedied by declaring duration functions that share the same function name with the timestamp functions using the new style when the UTC time fix is enabled.

… the partial declaration causes improper dynamic dispatch
Copy link

cici37 commented Jul 13, 2022

Thanks for addressing this. Tested in k8s side and it works as expected

@TristonianJones TristonianJones merged commit f3df06c into google:master Jul 13, 2022
2 checks passed
@TristonianJones TristonianJones deleted the duration-declaration-fix branch July 13, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants