Allow hammering with real certs copied from a source log #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 68.31% 67.57% -0.74%
==========================================
Files 82 84 +2
Lines 9972 10077 +105
==========================================
- Hits 6812 6810 -2
- Misses 2580 2686 +106
- Partials 580 581 +1
Continue to review full report at Codecov.
|
daviddrysdale
force-pushed
the
hammer
branch
4 times, most recently
from
060ee28
to
0973016
Compare
daviddrysdale
changed the title
Merged
daviddrysdale
force-pushed
the
hammer
branch
from
5aa65d7
to
10ca2ae
Compare
Martin2112
reviewed
Dec 10, 2018
Martin2112
approved these changes
Dec 10, 2018
Create a new type for synthetic cert generation and move the cert generation code into a new chains.go file. Also make the notAfter calculation a one-off, per-Log operation. Access this new SyntheticChainGenerator object via a new ChainGenerator interface, to allow for other test cert generators in future.
This provides another implementation of the ChainGenerator interface so that copied chains can be used interchangeably with synthetic chains in test tools.
This allow the tool to be re-used and generate different certs for add-[pre-]chain each time (assuming a large enough source log)
daviddrysdale
force-pushed
the
hammer
branch
from
0123620
to
d42d32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit shuffles a lot of code into different places but doesn't change behaviour much:
The significant new functionality is in:
And then there's two last commits that plumb the new function into the hammer
main: