Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexey comments #325

Merged
merged 12 commits into from Apr 14, 2021
Merged

Alexey comments #325

merged 12 commits into from Apr 14, 2021

Conversation

richsalz
Copy link
Contributor

@richsalz richsalz commented Mar 26, 2021

This addresses Alexey's comments that haven't already been resolved.

There is one open question about base64, posted to the list as https://mailarchive.ietf.org/arch/msg/trans/a0MXL0pqVRKi8NB8199YoUQRlpo/ Once I get confirmation I will take this out of WIP; commit 737b95f has the expected wording.

@google-cla
Copy link

@google-cla google-cla bot commented Mar 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

draft-ietf-trans-rfc6962-bis.md Outdated Show resolved Hide resolved
@google-cla
Copy link

@google-cla google-cla bot commented Mar 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@richsalz
Copy link
Contributor Author

@richsalz richsalz commented Mar 26, 2021

Confirmation from an expert (@AGWA) so taking this out of WIP.

(Edited to fix the atsign, was AG oops sorry.)

@richsalz richsalz changed the title WIP: Alexey comments Alexey comments Mar 26, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Mar 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

draft-ietf-trans-rfc6962-bis.md Outdated Show resolved Hide resolved
draft-ietf-trans-rfc6962-bis.md Outdated Show resolved Hide resolved
draft-ietf-trans-rfc6962-bis.md Outdated Show resolved Hide resolved
@google-cla
Copy link

@google-cla google-cla bot commented Mar 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Apr 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robstradling robstradling merged commit 5a32996 into google:master Apr 14, 2021
1 check failed
@richsalz richsalz deleted the alexey-comments branch Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants