Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof paths can be zero-length #326

Merged
merged 2 commits into from Apr 14, 2021
Merged

Proof paths can be zero-length #326

merged 2 commits into from Apr 14, 2021

Conversation

richsalz
Copy link
Contributor

@richsalz richsalz commented Mar 26, 2021

Ben Kaduk pointed out that the ConsistencyProofDataV2 and InclusionProofDataV2 had arrays that could not be empty. This was contradicted elsewhere in the document, so fix the 1.. to 0.. in both cases.

This should address the last part of Ben's DISCUSS.

@google-cla
Copy link

@google-cla google-cla bot commented Mar 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@richsalz richsalz changed the title Kaduk 3 Proof paths can be zero Mar 26, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Mar 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@richsalz richsalz changed the title Proof paths can be zero Proof paths can be zero-length Mar 26, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Mar 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

3 similar comments
@google-cla
Copy link

@google-cla google-cla bot commented Mar 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Mar 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Mar 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robstradling
Copy link
Collaborator

@robstradling robstradling commented Mar 30, 2021

The algorithm in Section 2.1.4.2 (Verifying Consistency between Two Tree Heads) requires at least 1 element in the consistency_path:
4. Set both "fr" and "sr" to the first value in the "consistency_path" array.

This section also says where "0 < first < second", which means that at least 1 element must be present for the consistency_path to be valid (because first != second). However, we can't assume that the consistency_path is valid until it has been validated.

So I suggest adding a new first step to the algorithm, with the following description:
If consistency_path is an empty array, stop the iteration and fail the proof verification.

WDYT?

@richsalz
Copy link
Contributor Author

@richsalz richsalz commented Mar 31, 2021

If consistency_path is an empty array, stop the iteration and fail the proof verification.

looks good; updated commit pushed.

@google-cla
Copy link

@google-cla google-cla bot commented Mar 31, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Apr 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Apr 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robstradling robstradling merged commit bf234a7 into google:master Apr 14, 2021
1 check failed
@richsalz richsalz deleted the kaduk-3 branch Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants