Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial suggestions from Benjamin Kaduk's IESG review #337

Merged
merged 1 commit into from Jul 12, 2021

Conversation

kaduk
Copy link
Contributor

@kaduk kaduk commented Jul 1, 2021

Mostly minor stuff, markdown and grammar nits and the like.

The one (?) exception is changing the presentation language for an opaque signature<> entry to have a minimum length of 1 instead of 0. There are two opaque signature<> elements in the document, and the other one already had this change applied due to a previous review of mine, so I claim it still is effectively "minor".

@google-cla
Copy link

@google-cla google-cla bot commented Jul 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robstradling robstradling merged commit 08e59b3 into google:master Jul 12, 2021
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants