This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix horizontal follow line to match vertical follow line #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorrainekan
pushed a commit
that referenced
this pull request
Aug 28, 2019
The horizontal follow line for `LinePointHighlighter` behavior was always being drawn as a dashed line and could not be changed. This change makes it match the vertical follow line pattern which can be changed with the `dashPattern` parameter. Closes #238 PiperOrigin-RevId: 265520297
spencerreeves
pushed a commit
to apt304/charts
that referenced
this pull request
Mar 4, 2020
* Fix horizontal follow line to match vertical follow line The horizontal follow line for `LinePointHighlighter` behavior was always being drawn as a dashed line and could not be changed. This change makes it match the vertical follow line pattern which can be changed with the `dashPattern` parameter. Closes google#238 PiperOrigin-RevId: 265520297 * Fixed import clash for Point class On Flutter master, when targeting web, the following error occurs: packages/charts_flutter/src/behaviors/zoom/pan_behavior.dart:17:1: Error: 'Point' is imported from both 'dart:math' and 'dart:ui'. import 'dart:ui'; I updated the import to read: import 'dart:ui' show lerpDouble; Closes google#284 PiperOrigin-RevId: 265534847 * Fix issue google#116 - Exception using desiredMaxColumns in SeriesLegend Fix issue google#116 Padding rows using a Padding widget and not a Row widget. Specifying type Iterable<Padding> in the generator. Closes google#192 PiperOrigin-RevId: 265555440 * Fixing ArcRendererConfig(stroke color) The stroke color is set to white by default but couldn't be modified. I add an `arcStrokeColor` value to Style class. So it can be changed by replace customized style. Closes google#197 PiperOrigin-RevId: 265572617 * Update versioning. PiperOrigin-RevId: 265676481 * Internal changes. PiperOrigin-RevId: 265794470
JackMoseley2001
pushed a commit
to JackMoseley2001/charts
that referenced
this pull request
Nov 1, 2021
* Fix horizontal follow line to match vertical follow line The horizontal follow line for `LinePointHighlighter` behavior was always being drawn as a dashed line and could not be changed. This change makes it match the vertical follow line pattern which can be changed with the `dashPattern` parameter. Closes google#238 PiperOrigin-RevId: 265520297 * Fixed import clash for Point class On Flutter master, when targeting web, the following error occurs: packages/charts_flutter/src/behaviors/zoom/pan_behavior.dart:17:1: Error: 'Point' is imported from both 'dart:math' and 'dart:ui'. import 'dart:ui'; I updated the import to read: import 'dart:ui' show lerpDouble; Closes google#284 PiperOrigin-RevId: 265534847 * Fix issue google#116 - Exception using desiredMaxColumns in SeriesLegend Fix issue google#116 Padding rows using a Padding widget and not a Row widget. Specifying type Iterable<Padding> in the generator. Closes google#192 PiperOrigin-RevId: 265555440 * Fixing ArcRendererConfig(stroke color) The stroke color is set to white by default but couldn't be modified. I add an `arcStrokeColor` value to Style class. So it can be changed by replace customized style. Closes google#197 PiperOrigin-RevId: 265572617 * Update versioning. PiperOrigin-RevId: 265676481 * Internal changes. PiperOrigin-RevId: 265794470
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The horizontal follow line for
LinePointHighlighterbehavior was always being drawn as a dashed line and could not be changed. This change makes it match the vertical follow line pattern which can be changed with thedashPatternparameter.