Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal error when calling clasp logs with invalid projectId and refactor clasp logs #535

Merged
merged 13 commits into from Feb 17, 2019

Conversation

@tawAsh1
Copy link
Contributor

commented Feb 15, 2019

Fixes #518, #501

move clasp logs code out to separate file.
project id regexp from here.
https://cloud.google.com/resource-manager/reference/rest/v1beta1/projects

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

tawAsh1 added some commits Feb 15, 2019

@googlebot

This comment has been minimized.

Copy link

commented Feb 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot googlebot added the cla: no label Feb 15, 2019

@tawAsh1

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Feb 15, 2019

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 15, 2019

@grant grant requested a review from campionfellin Feb 15, 2019

src/commands.ts Outdated Show resolved Hide resolved
src/commands.ts Outdated Show resolved Hide resolved
@campionfellin
Copy link
Collaborator

left a comment

Besides a couple small points, this would be nice to be refactored into

commands/log.ts as part of work towards #501 if you want to take on additional work. Otherwise, LGTM.

tawAsh1 added some commits Feb 16, 2019

@tawAsh1 tawAsh1 changed the title Fix terminal error when calling clasp logs with invalid projectId Fix terminal error when calling clasp logs with invalid projectId and refactor clasp logs Feb 16, 2019

grant added some commits Feb 17, 2019

@googlebot

This comment has been minimized.

Copy link

commented Feb 17, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 17, 2019

@grant grant added cla: yes and removed cla: no labels Feb 17, 2019

@googlebot

This comment has been minimized.

Copy link

commented Feb 17, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers can find more info about SignCLA and this PR by following this link.

@grant grant merged commit 328b7dc into google:master Feb 17, 2019

2 checks passed

cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grant

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

Thank you for your contribution @tawAsh1! I've merged the PR.

@caputchinefrobles

This comment has been minimized.

Copy link

commented Mar 9, 2019

Hi. Thanks for the fix. Do you have any idea when the next release with the fix will be available? I'm having such a hard time without clasp logs.

Thank's again.

campionfellin added a commit to campionfellin/clasp that referenced this pull request Apr 7, 2019

Fix terminal error when calling clasp logs with invalid projectId and…
… refactor clasp logs (google#535)

* Add error for projectid error

* Validate projectId and fix google#518

* remove unused import

* Add project id validation method

* Move switch statement in a method

* linting

* Refactor clasp logs

* Refactor clasp logs

* Update index.ts

* Update index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.