Add support for browser field advanced usage to package.json processing #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChadKillingsworth
approved these changes
Aug 8, 2017
blickly
reviewed
Aug 8, 2017
| @@ -36,6 +36,8 @@ | |||
| implements CompilerPass { | |||
| public static final DiagnosticType JSON_UNEXPECTED_TOKEN = | |||
| DiagnosticType.error("JSC_JSON_UNEXPECTED_TOKEN", "Unexpected JSON token"); | |||
| public static final String JSC_BROWSER_BLACKLISTED_MARKER = "$jscomp$browser$blacklisted"; | |||
There was a problem hiding this comment.
It's not easy for us to add a dependency from the deps package onto the jscomp package. Is it possible to move the definition of JSC_BROWSER_BLACKLISTED_MARKER into the deps package?
There was a problem hiding this comment.
just did this in a separate commit for easier review. Let me know if it looks good and I'll squash them
|
LGTM, thanks! |
|
Awesome. Just rebased on current master & squashed commits. |
|
Nice, importing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the last milestone in adding full support for the browser field when processing
package.jsonfiles.Fixes #2433
cc @ChadKillingsworth