New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable renaming for the JS compiler #2707

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gaearon
Contributor

gaearon commented Nov 7, 2017

Fixes #2690.

I used the approach suggested by @ChadKillingsworth in #2690 (comment), but apply it to GwtRunner (since I need this to be exposed in the JS version) as suggested by @anmonteiro in #2690 (comment).

This adds a new renaming option to the JS version.

It defaults to true:

screen shot 2017-11-07 at 4 07 33 pm

When set to false, it produces a build that doesn't minify variable or property names:

screen shot 2017-11-07 at 4 06 42 pm

It can only be set to false for SIMPLE mode. Doing so in ADVANCED mode throws:

screen shot 2017-11-07 at 4 08 21 pm

I need this option to move React builds completely to Google Closure Compiler. I’m happy to also include changes to expose this option to Java consumers, if you’d like, but I figured it’s best to send a PR with the minimal scope.

I’m sending this PR on the individual behalf not on company time. The code belongs to me.

@dimvar

This comment has been minimized.

Show comment
Hide comment
@dimvar

dimvar Nov 7, 2017

Contributor

LGTM. I will bring this internally for testing.

Contributor

dimvar commented Nov 7, 2017

LGTM. I will bring this internally for testing.

@dimvar dimvar closed this in 5faf29c Nov 9, 2017

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 9, 2017

Contributor

Thank you!

Contributor

gaearon commented Nov 9, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment