Improve CommonJS UMD pattern detection #2963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks to see if the enclosing "if" test references the "module" or "define" names. Prevents exports nested in IF clauses from being always detected as a UMD pattern when they may just be performing a conditional export.
swannodette
pushed a commit
to clojure/clojurescript
that referenced
this pull request
Jun 14, 2018
One important fix in the latest Closure-compiler is fix for UMD wrapper detection which now correctly leaves React CJS bundle intact. google/closure-compiler#2841 google/closure-compiler#2963
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this pull request
Jul 16, 2018
Checks to see if the enclosing "if" test references the "module" or "define" names. Prevents exports nested in IF clauses from being always detected as a UMD pattern when they may just be performing a conditional export. Closes google#2963 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=199227525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have historically detected the Universal Module Definition pattern by looking for an export nested inside any
ifstatement. However, this is far from correct. In CommonJS, exports can be conditionally created.Improves the UMD pattern detection by requiring the
ifstatement to reference themoduleordefinenames.In addition, the pass now creates export aliases for any export nested inside an
iforfunction. Rewriting such exports to avoid aliases potentially produced incorrect code.Fixes #2841