Switches CommonJS modules to use the module metadata map #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata provides the module type of the imported module. Also adds module interop integration tests. Fixes google#3360
jplaisted
reviewed
Jun 11, 2019
| LINE_JOINER.join( | ||
| "var $jscomp$destructuring$var0 = module$i0.default;", | ||
| "var foo$$module$i1 = $jscomp$destructuring$var0.foo;", | ||
| "var b$$module$i1 = module$i0.bar();", |
There was a problem hiding this comment.
Is this a typo? Shouldn't it be module$i0.default.bar?
jplaisted
reviewed
Jun 11, 2019
| @@ -262,11 +261,127 @@ public void testCrossModuleSubclass6() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCommonJSImportsESModule() { | |||
There was a problem hiding this comment.
Also fwiw I'm pretty sure I had nothing to do with this one since I didn't touch the CJS pass :)
I'll take a look at the others, but can you handle this one?
blickly
added
the
internal-issue-created
|
Internal issue created http://b/135037612 |
|
Please sync after ec31e72. I've fixed ES modules importing CJS modules. |
|
Hi Chad, are you still interested in merging this PR? |
|
I'll pick this up again some day, but I will start a new PR. This is too stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata provides the module type of the imported module. Also adds module interop integration tests.
I added 2 failing tests that need fixed. Both seem to indicate a problem with ES Module rewriting and default properties.
Fixes #3360