Permalink
Commits on Jan 22, 2019
  1. Make the parameters to assertSameElements non-nullable.

    nanaze authored and shicks committed Jan 17, 2019
    RELNOTES[INC]: assertSameElements no longer accepts nulls
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229759723
  2. Automated g4 rollback of changelist 224520993.

    shicks committed Jan 17, 2019
    *** Reason for rollback ***
    
    b/120531468 is fixed, so the workaround is no longer needed.
    
    *** Original change description ***
    
    KeyboardShortcutHandler: Force a function call to prevent Closure compiler from inlining a call to goog.object.createSet. This led to a bug that would appear only in compiled (minified) mode.
    
    RELNOTES: n/a
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229740672
  3. Automated g4 rollback of changelist 229469160.

    shicks committed Jan 16, 2019
    *** Reason for rollback ***
    
    breaks multiple continuous builds, including Gmail
    
    *** Original change description ***
    
    Lighten the code overhead of goog.async.run by reverting the use of goog.async.WorkQueue instead us a simple array.  We don't have any tests or data showing that WorkQueue actually improves things.
    
    RELNOTES: n/a
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229489466
  4. Lighten the code overhead of goog.async.run by reverting the use of g…

    concavelenz authored and shicks committed Jan 16, 2019
    …oog.async.WorkQueue instead us a simple array. We don't have any tests or data showing that WorkQueue actually improves things.
    
    RELNOTES: n/a
    
    RELNOTES=n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229469160
  5. Tighten the type of the first parameter of intersection() to match th…

    nanaze authored and shicks committed Jan 15, 2019
    …e TC39
    
    definition (for which "this" is a Set, not an Iterable).
    
    This simplifies implementation and makes future migrations automatable.
    
    RELNOTES[INC]: Tightens parameter types on goog.collections.sets.intersection.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229433201
  6. Simplify test file using method definition in object initializer syntax

    nanaze authored and shicks committed Jan 15, 2019
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229399741
  7. Fix typos from CL 229196911.

    shicks committed Jan 15, 2019
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229387235
  8. RELNOTES[NEW]: Add goog.dom.safe.parseFromStringHtml.

    vrana authored and shicks committed Jan 15, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229384090
  9. Add type annotations to eliminate compiler warnings.

    nanaze authored and shicks committed Jan 15, 2019
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229281673
  10. Rolling forward CL 228530531:

    shicks committed Jan 14, 2019
    Safe alternative to creating an image element from a blob.
    
    RELNOTES[NEW]: Added a helper function that guarantees revoking the object url created from createObjectUrl when creating an Image element from a blob with MIME type image/.*.
    
    Also whitelists use of createObjectUrl in goog.dom.safe with MANUALLY_REVIEWED
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229243997
  11. JS Compiler release r20190113: update transpile.js

    brad4d authored and shicks committed Jan 14, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229219463
  12. Always treat Edge as an ES5 browser. The Reflect.construct test is fl…

    jplaisted authored and shicks committed Jan 14, 2019
    …aky supposedly an issue if the JIT runs or not.
    
    Example: If I try running a test it says Edge is ES5 since the Reflect.construct test fails, but if I open the debug tools it says it is ES8 since the same test passes.
    
    RELNOTES[NEW]: Always treat Edge as an ES5 browser.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229196911
  13. RELNOTES[NEW]: Make labs mock compatible with an ES6 subclass when gi…

    jplaisted authored and shicks committed Jan 14, 2019
    …ven the constructor/class itself.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229106862
  14. Implement filter() for ES6 iterables.

    nanaze authored and shicks committed Jan 12, 2019
    RELNOTES[NEW]: Adds goog.labs.iterable.filter
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228987705
  15. Update goog.labs.iterableTest to use ES6 syntax as Closure now suppor…

    nanaze authored and shicks committed Jan 12, 2019
    …ts ES6 syntax.
    
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228986714
  16. Update goog.labs.iterable to use ES6 syntax as Closure now supports E…

    nanaze authored and shicks committed Jan 12, 2019
    …S6 syntax.
    
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228982063
  17. make toArray_ param non-null

    nanaze authored and shicks committed Jan 12, 2019
    RELNOTES: n/a No public API change.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228981489
  18. Move goog.collections.set to goog.collections.sets per request.

    nanaze authored and shicks committed Jan 12, 2019
    RELNOTES[INC]: Moves goog.collections.set to goog.collections.sets
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228981184
Commits on Jan 11, 2019
  1. Add goog.collections.set, add the first of the four operations (inter…

    nanaze authored and nreid260 committed Jan 10, 2019
    …section).
    
    RELNOTES[NEW]: Added goog.collections.set and intersection operation.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228785796
  2. Automated g4 rollback of changelist 227940964.

    nreid260 committed Jan 10, 2019
    *** Reason for rollback ***
    
    Rollforward with EventType fix. Instead of checking useragent, check for the existence
    of the [prefix]requestFullscreen methods and use that to determine the event type.
    Also reorders the other methods so that requestFullscreen is before the webkit version.
    
    RELNOTES[NEW]: Add support for FullscreenOptions in requestFullscreen utility
    
    *** Original change description ***
    
    Automated g4 rollback of changelist 226359674.
    
    *** Reason for rollback ***
    
    I believe this CL has resulted in a fullscreen regression in our app: http://b/122101460
    
    It also looks like there is a logical error in this CL. The ordering change means that Chrome will now be calling requestFullscreen() instead of webkitRequestFullscreen(). However, goog.dom.fullscreen.EventType was not updated, so users referencing EventType.CHANGE will still be listening for `webkitfullscreenchange` not `fullscree...
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228764798
  3. run of genjsdeps at head in clean client

    nanaze authored and nreid260 committed Jan 10, 2019
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228730068
  4. Automated g4 rollback of changelist 228530531.

    nreid260 committed Jan 10, 2019
    *** Reason for rollback ***
    
    Breakage
    
    *** Original change description ***
    
    Safe alternative to creating an image element from a blob.
    
    RELNOTES[NEW]: Added a helper function that guarantees revoking the object url created from createObjectUrl when creating an Image element from a blob with MIME type image/.*.
    
    Also whitelists use of createObjectUrl in goog.dom.safe with MANUALLY_REVIEWED
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228618069
Commits on Jan 9, 2019
  1. Safe alternative to creating an image element from a blob.

    nreid260 committed Jan 9, 2019
    RELNOTES[NEW]: Added a helper function that guarantees revoking the object url created from createObjectUrl when creating an Image element from a blob with MIME type image/.*.
    
    Also whitelists use of createObjectUrl in goog.dom.safe with MANUALLY_REVIEWED
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228530531
  2. RELNOTES[NEW]: [goog.dom.asserts] Added missing assertIsHTMLTextAreaE…

    nreid260 committed Jan 8, 2019
    …lement() and assertIsHTMLCanvasElement().
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228281054
  3. Enable recording broadcasted events.

    nreid260 committed Jan 8, 2019
    This is step 1.
    
    Step 2 will be to try to flip this to the default by finding all tests that fail. But in the meantime, people can use this method.
    
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228274939
  4. JS Compiler release r20190106

    brad4d authored and nreid260 committed Jan 7, 2019
    Release notes: go/jscompiler-releases
    Release policy: go/jscompiler-internal-release-policy
    
    To report problems with this release, please email:
    js-compiler-users@google.com, jscomp-team@google.com
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228213350
  5. Add a new flag to the debug loader to help avoid double server/client…

    jplaisted authored and nreid260 committed Jan 7, 2019
    … side transpilation. Right now our test server will transpile server side, but we still require transpiling client side as well for ES6 modules only to preserve the loading logic, not the transpilation itself.
    
    This new flag tells the debug loader that ES6 modules have been pre-transformed to jscomp modules, and thus transpilation should be skipped but the loading logic of transpiled modules preserved.
    
    RELNOTES: none
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228200959
  6. Automated g4 rollback of changelist 226359674.

    nreid260 committed Jan 5, 2019
    *** Reason for rollback ***
    
    I believe this CL has resulted in a fullscreen regression in our app: http://b/122101460
    
    It also looks like there is a logical error in this CL. The ordering change means that Chrome will now be calling requestFullscreen() instead of webkitRequestFullscreen(). However, goog.dom.fullscreen.EventType was not updated, so users referencing EventType.CHANGE will still be listening for `webkitfullscreenchange` not `fullscreenchange`.
    
    *** Original change description ***
    
    Add options to requestFullscreen closure utility function
    
    Also reorders the checks so that "requestFullscreen" is first. The other prefixes
    should be fallbacks only when requestFullscreen is not available.
    
    RELNOTES[NEW]: Add support for FullscreenOptions in requestFullscreen utility
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=227940964
  7. Rename private variable.

    vrana authored and nreid260 committed Jan 4, 2019
    Also delete unrelated comment.
    
    RELNOTES: None.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=227780166
  8. Automated g4 rollback of changelist 226695948.

    rpelizzi authored and nreid260 committed Jan 3, 2019
    *** Reason for rollback ***
    
    Causes b/122281896
    
    *** Original change description ***
    
    Support for custom namespaces in whitelists and policies, adding support in the unsafe package as well. Also preserve case when sanitizing
    
    RELNOTES[NEW]: The HTML sanitizer unsafe package can now whitelist element and attributes in non-HTML namespaces (e.g. SVG)
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=227755562
  9. Fix numeric formatting to use quantity value of negative zero for uni…

    nreid260 committed Jan 3, 2019
    …ts in the past, positive zero for future, e.g., "0 minutes ago" vs. "in 0 minutes."
    
    RELNOTES: Fix goog.i18n.RelativeDateTimeFormat to use quantity value of negative zero to format zero units as past rather than future.
    
    In the previous release, a quantity with value zero gives a future format, e.g., "in 0 minutes". With this update, the caller may specify a negative zero value which will select the past form, e.g., "0 minutes ago".
    
    This change allows the caller to choose the specific direction of time when a value of zero is needed.
    
    The two values of zero are part of the floating point standard IEEE 754. Since regular comparison in JavaScript does not distinguish the two signed zero values, it is necessary to divide positive infinity by the zero value. A result of negative infinity indicates negative zero, otherwise the value was positive zero.
    
    The change applies to all units and all locales.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=227722147
Commits on Jan 2, 2019
  1. Support for custom namespaces in whitelists and policies, adding supp…

    rpelizzi authored and shicks committed Dec 23, 2018
    …ort in the unsafe package as well. Also preserve case when sanitizing
    
    RELNOTES[NEW]: The HTML sanitizer unsafe package can now whitelist element and attributes in non-HTML namespaces (e.g. SVG)
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=226695948
  2. Remove unneeded dependency on goog.testing.ObjectPropertyString.

    concavelenz authored and shicks committed Dec 21, 2018
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=226549714
  3. Allow max attribute in progress in JS HTML sanitizer

    shicks committed Dec 21, 2018
    RELNOTES: The HTML sanitizer should allow the "max" attribute (which is defined on "progress" element).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=226513950
  4. Eliminates prototypal inheritance errors related to class-side inheri…

    shicks committed Dec 21, 2018
    …tance.
    
    This CL is a preparatory step to prevent build errors caused by the addition of checks in CL/215669793.
    
    RELNOTES: n/a
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=226510264