Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove UA sniffing around event.keyCode/charCode for keypress events in Firefox #932
In order to ship
Our plan is to essentially do what Chrome does, explained by the first part of the commit message:
However, once we landed this we discovered that keyboards shortcuts break in sites using Closure break (GMail, GSuite, Remember The Milk, etc).
Places that need to be updated (possibly more?) to not expect a Firefox UA string will have 0 for
Thanks for reporting this. We've tried testing with Firefox Nightly on both OS X and Linux, enabling the
Can you give a more specific repro case? Thanks!
Hi @jplaisted, thanks!
Here's more specific pointers to bugs, with better STR, all assuming
It says the user was not able to type certain keys.
Note: I'm testing on OSX 10.13.6, using Firefox Nightly 64.0a1 (2018-10-15) (64-bit)
The new behavior can be detected with:
Note that Gecko won't take the new behavior without stopping dispatching non-printable keypress events. So, you need to treat only Enter key press specially if keyCode and charCode are same.