Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--nojsdoc option is broken in 2.3.10 #64

Closed
GoogleCodeExporter opened this issue Jun 17, 2015 · 6 comments
Closed

--nojsdoc option is broken in 2.3.10 #64

GoogleCodeExporter opened this issue Jun 17, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

Even if you set --nojsdoc, closure-linter will still report those errors.

See https://travis-ci.org/mozilla-b2g/gaia/builds/7043293 for one example of 
doc errors being reported.

Original issue reported on code.google.com by rik...@gmail.com on 10 May 2013 at 10:33

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

Confirmed
After upgrading my node wrapper[1], my test are broken

Meanwhile this is fixed, you can use the following flag
--disable 220

[1] https://github.com/jmendiara/node-closure-linter-wrapper

Original comment by jmendi...@gmail.com on 15 May 2013 at 2:03

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

It seems some parenthesis are missing in errorrules.py

PATCH:
find:
errors.MISSING_JSDOC_TAG_THIS)) and 
          not FLAGS.disable or error not in disabled_error_nums)

replace with:
errors.MISSING_JSDOC_TAG_THIS)) and (
          not FLAGS.disable or error not in disabled_error_nums)) 

Original comment by jmendi...@gmail.com on 15 May 2013 at 2:24

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

could we fix this please ?

Original comment by fel...@gmail.com on 21 Jun 2013 at 1:23

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

Here's the patch, fixes the problem for me.

Original comment by fel...@gmail.com on 21 Jun 2013 at 1:26

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

I'll handle this one.

Original comment by vagra...@google.com on 29 Jul 2013 at 5:38

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jun 17, 2015

Original comment by vagra...@google.com on 29 Jul 2013 at 5:30

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.