Skip to content
Permalink
Browse files

Remove references to shouldGenerateJsdoc since the default value is t…

…rue and there is no need to manually set it.

Tested:
    []_presubmit: []    Some tests failed; test failures are believed to be unrelated to this CL

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=171725481
  • Loading branch information...
Soy Authors authored and emspishak committed Oct 10, 2017
1 parent 69b6df2 commit 75cb41a9dace6c4eec723c648327c5c65228a385
@@ -99,8 +99,6 @@ most of expressions. Here are the major incompatibilities.

## Eliminate legacy compiler options

* --shouldGenerateJsdoc eliminate the flag, there is no reason not to always
do this.
* --isUsingIjData flip to true, delete flag
* --codeStyle remove flag, it is dead
* --shouldProvideRequireSoyNamespaces and
@@ -37,7 +37,6 @@ SoyJsSrcOptions toJsSrcOptions() {
jsSrcOptions.setShouldProvideRequireJsFunctions(false);
jsSrcOptions.setShouldProvideBothSoyNamespacesAndJsFunctions(false);
jsSrcOptions.setShouldDeclareTopLevelNamespaces(false);
jsSrcOptions.setShouldGenerateJsdoc(true);
// Only goog.module generation supported
jsSrcOptions.setShouldGenerateGoogModules(true);
jsSrcOptions.setShouldGenerateGoogMsgDefs(true);

0 comments on commit 75cb41a

Please sign in to comment.
You can’t perform that action at this time.