Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch, add types to descriptormap #477

Open
notzed opened this issue Dec 27, 2019 · 3 comments
Open

patch, add types to descriptormap #477

notzed opened this issue Dec 27, 2019 · 3 comments

Comments

@notzed
Copy link

@notzed notzed commented Dec 27, 2019

I've been working on a simple script to generate some of the boilerplate and having the types in the output makes it much simpler.

So here's a work in progress patch for adding the function argument types to the descriptormap output. I'm attaching it here for discussion & rejection or improvement.

clspv-types-0.diff.txt

@alan-baker

This comment has been minimized.

Copy link
Collaborator

@alan-baker alan-baker commented Jan 3, 2020

Can you expand on why you want types added to the descriptor map? None of the integrations of clspv I'm aware of have found that to be necessary. What kind of boilerplate code are you generating?

@kpet

This comment has been minimized.

Copy link
Contributor

@kpet kpet commented Jan 5, 2020

@alan-baker This will be needed by clvk ultimately to support clGetKernelArgInfo (see https://www.khronos.org/registry/OpenCL/sdk/2.1/docs/man/xhtml/clGetKernelArgInfo.html). There is a Clang option to emit all the information required as metadata (see EmitOpenCLArgMetadata in Compiler.cpp). We need to decide how to represent it the descriptor map (or introduce another interface) and enable the behaviour with a new -cl-kernel-arg-info option. All passes that manipulate function signatures would require some work (thinking ClusterPodKernelArgumentsPass at least).

@notzed +1 with Alan's questions. I'm really curious to know why you need it.

@notzed

This comment has been minimized.

Copy link
Author

@notzed notzed commented Jan 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.