Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add some initial content for the Job Definition Reference page. #107

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Feb 6, 2019

I left some TODOs, and there is definitely some other important things we should add to this page, but let's start from at least something, it's already a big CL

docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved

Jobs can be created or edited on the *Jobs* page. A job definition mostly
consists of environment variables. If you use a job template when configuring a
job, the template will add the variables that are specified in the job template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe say about conflicting variable and precedence order ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather avoid making any promises regarding the order. It's better not to duplicate and not to overwrite values :)

docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mbarbella-chromium mbarbella-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but lgtm overall.

docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
docs/setting-up-fuzzing/job_definition_reference.md Outdated Show resolved Hide resolved
@Dor1s
Copy link
Contributor Author

Dor1s commented Feb 6, 2019

Thanks a lot for the comments!

@Dor1s Dor1s merged commit 9c728ef into master Feb 6, 2019
@inferno-chromium inferno-chromium deleted the job_reference branch February 6, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants