Repository navigation
Use the engine interface with AFL on a trial basis. - #2147
Merged
Merged
Conversation
Contributor
Author
|
/gcbrun |
This is intended to facilitate later changes which will allow us to delete launcher.py, though in the short-term this adds some extra complexity (duplicate code across the two files). That said, new changes need not be backported to launcher.py.
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
mbarbella-chromium
changed the title
Contributor
Author
|
Still needs a small amount of work to get tests passing. Feel free to take a look now if you want, but I'll update this again once everything is green. |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
Tests are now passing. |
oliverchang
reviewed
Dec 4, 2020
oliverchang
left a comment
oliverchang
left a comment
Collaborator
There was a problem hiding this comment.
nice! some initial comments.
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
oliverchang
approved these changes
Dec 8, 2020
oliverchang
left a comment
oliverchang
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Some additional comments, but LGTM overall. Please test this carefully.
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
I'll hold off on landing this until after the progression cron runs to give myself a bit more time for manual testing. All comments should be addressed, and tests are all passing. |
Contributor
Author
|
Spoke to Oliver via chat. We'll just land this now and monitor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet ready for review. This still needs a bit of cleanup and much more careful testing.