Skip to content

Conversation

@kantasv
Copy link
Collaborator

@kantasv kantasv commented Sep 3, 2023

Hi, JA translation folks (#652), here's a MR for the chapter "Send and Sync". This chapter is particularly interesting and contains very rust-specific concepts which seems unfamiliar to me. Any feedback and suggestions are welcome :)

msgid ""
"`Send` and `Sync` are [unsafe traits](../unsafe/unsafe-traits.md). The "
"compiler will automatically derive them for your types as long as they only "
"contain `Send` and `Sync` types. You can also implement them manually when "
Copy link
Collaborator Author

@kantasv kantasv Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentenses around here were difficult for me to figure out what "they", and "them" are. Possibly I might send a request for clarifications for original English content if I have some time and energy :) Probably original authors might be able to autocomplete them in their brain, but for those who are begineers, like me, often it would be nice we have concrete descriptions rather than "it", "this", "them", and "they".

Copy link
Collaborator

@HidenoriKobayashi HidenoriKobayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random & premature comments
I need to run for now
I may come back again to correct my comments

@kantasv
Copy link
Collaborator Author

kantasv commented Sep 6, 2023

Kudos to @HidenoriKobayashi for giving me concrete and helpful suggestions! Thank you. @keiichiw or @chikoski, when you have some time, could you skim thru or merge the MR?

Copy link
Contributor

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on vacation. Here are my review comments.

@kantasv
Copy link
Collaborator Author

kantasv commented Sep 18, 2023

Hi, @keiichiw thanks for providing concrete feedback with reference, which helped me a lot to learn the concepts behind the scenes! I have incorporated your suggestions. Could you reveiw it once again? Thank you!

Copy link
Collaborator

@chikoski chikoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for my late response. The translation looks good overall. I put some comments for minor editorial things. Please take a look at it.

@kantasv
Copy link
Collaborator Author

kantasv commented Sep 24, 2023

Hi @chikoski, thanks for concrete suggestions. They're generally helpful and applicable to my future translations, too :) I've accepted your suggestions. Could someone merge it if it looks good? Thank you!

@chikoski chikoski merged commit a9183eb into google:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants