From 922ff50c10bc6486b495c7340b4909398d0df2de Mon Sep 17 00:00:00 2001 From: Wanying Ding Date: Mon, 4 Mar 2024 13:20:14 -0800 Subject: [PATCH] reduce number of times resolving parameter types in an extreme case. RELNOTES=n/a PiperOrigin-RevId: 612562471 --- .../codegen/xprocessing/XElements.java | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/java/dagger/internal/codegen/xprocessing/XElements.java b/java/dagger/internal/codegen/xprocessing/XElements.java index b63d4d93d6e..2f7efced91b 100644 --- a/java/dagger/internal/codegen/xprocessing/XElements.java +++ b/java/dagger/internal/codegen/xprocessing/XElements.java @@ -329,16 +329,22 @@ public static String toStableString(XElement element) { return asTypeElement(element).getQualifiedName(); } else if (isExecutable(element)) { XExecutableElement executable = asExecutable(element); + // TODO(b/318709946) resolving ksp types can be expensive, therefore we should avoid it + // here for extreme cases until ksp improved the performance. + boolean tooManyParameters = + getProcessingEnv(element).getBackend().equals(XProcessingEnv.Backend.KSP) + && executable.getParameters().size() > 10; return String.format( "%s(%s)", getSimpleName( - isConstructor(element) - ? asConstructor(element).getEnclosingElement() - : executable), - executable.getParameters().stream() - .map(XExecutableParameterElement::getType) - .map(XTypes::toStableString) - .collect(joining(","))); + isConstructor(element) ? asConstructor(element).getEnclosingElement() : executable), + (tooManyParameters + ? executable.getParameters().stream().limit(10) + : executable.getParameters().stream() + .map(XExecutableParameterElement::getType) + .map(XTypes::toStableString) + .collect(joining(","))) + + (tooManyParameters ? ", ..." : "")); } else if (isEnumEntry(element) || isField(element) || isMethodParameter(element)