Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add a method in BindingGraphPlugin to know when all graphs are visited. #3483

Closed
arunkumar9t2 opened this issue Jul 26, 2022 · 0 comments

Comments

@arunkumar9t2
Copy link

arunkumar9t2 commented Jul 26, 2022

Currently BindingGraphPlugin has only one method visitGraph which gets called for each BindingGraph.

However for component dependencies or any other use cases where we want access to Bindings in another graph currently it is not possible unless annotation processor output is manually post processed. A callback from Dagger when all graphs are processed would be helpful for the SPI plugin to collect all the graphs and perform work in this method where all bindings would be accessible.

This is similar to BindingGraphCapturer used in tests.

Use-case: Binding graph visualizations.

copybara-service bot pushed a commit that referenced this issue Jul 26, 2022
Fixes #3483.

RELNOTES=Add onPluginEnd to BindingGraphPlugin. Fixes #3483
PiperOrigin-RevId: 463211283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant