Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support constructor with content layout id for AndroidX

Closed
wants to merge 2 commits into from

Conversation

chibatching
Copy link

@chibatching chibatching commented Feb 17, 2020

To resolve the issue #1734

This PR add constructor with content layout id for AndroidX version DaggerAppCompatActivity and DaggerFragment.

@danysantiago
Copy link
Member

danysantiago commented Feb 19, 2020

Thanks for making this, it looks good to me so I'll go ahead and patch it internally.

@kluever kluever mentioned this pull request Feb 21, 2020
kluever pushed a commit that referenced this issue Feb 21, 2020
This PR add constructor with content layout id for AndroidX version
DaggerAppCompatActivity and DaggerFragment.

Fixes #1734
Closes #1741

RELNOTES=Add support constructor with content layout id for AndroidX

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=296257246
kluever pushed a commit that referenced this issue Feb 21, 2020
This PR add constructor with content layout id for AndroidX version
DaggerAppCompatActivity and DaggerFragment.

Fixes #1734
Closes #1741

RELNOTES=Add support constructor with content layout id for AndroidX

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=296257246
@chibatching chibatching deleted the add_layout_constructor branch Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants