Libraries should not specify a targetSdkVersion. #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's optional, changes no behavior (from the library's perspective), and participates in manifest merging which can cause problems should the user have a lower target.
|
Ah, I didn't realize it wasn't required. I'll pull this in, thanks! |
ronshapiro
added a commit
that referenced
this pull request
Feb 28, 2017
Fixes #591 (for dagger.android and dagger.android.support) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148670273
ronshapiro
added a commit
that referenced
this pull request
Mar 2, 2017
Fixes #591 (for dagger.android and dagger.android.support) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148670273
This was referenced May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's optional, changes no behavior (from the library's perspective), and participates in manifest merging which can cause problems should the user have a lower target.