Ensure bundle_libraries is called with uppercase link type#56
Closed
eliemichel wants to merge 1 commit into
Closed
Ensure bundle_libraries is called with uppercase link type#56eliemichel wants to merge 1 commit into
eliemichel wants to merge 1 commit into
Conversation
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
copybara-service Bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
In the root CMakeLists.txt, a call to `TOUPPER` suggests that the value of `DAWN_BUILD_MONOLITHIC_LIBRARY` might have any case. However, its value is used as is in the call to `bundle_libraries`, which in turn uses it in a call to `add_library`, which requires uppercase `STATIC`or `SHARED`. This ensures that the argument passed to `bundle_libraries` is uppercased. Another fix could be to place a call to `TOUPPER`directly within `bundle_libraries`'s definition. This is an imported pull request from #56 GITHUB_PR_HEAD_SHA=2ce3a5f3290dd763804d1f5c6170edf756943502 ORIGINAL_AUTHOR=Elie Michel <eliemichel@users.noreply.github.com> GitOrigin-RevId: 69ce404 Change-Id: Ibfea2cdc67b45142c5d7916e4a2a48b74524d2cd Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/285403 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
|
🚀 PR was merged in 609ad4a! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the root CMakeLists.txt, a call to
TOUPPERsuggests that the value ofDAWN_BUILD_MONOLITHIC_LIBRARYmight have any case. However, its value is used as is in the call tobundle_libraries, which in turn uses it in a call toadd_library, which requires uppercaseSTATICorSHARED.This ensures that the argument passed to
bundle_librariesis uppercased. Another fix could be to place a call toTOUPPERdirectly withinbundle_libraries's definition.