Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add click to copy button to code samples #1245

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

geriom
Copy link
Collaborator

@geriom geriom commented Sep 28, 2022

Adds a click to copy button to code samples that don't use the Prism highlighter.

This implementation requires the latest version of Popper. I ran a grep on the whole website and couldn't find any other Popper instances. So it seems updating the Popper library won't affect anything.

Screenshots

Normal view Mouseover Clicked
Screenshot from 2022-09-28 17-11-19 Screenshot from 2022-09-28 17-11-31 Screenshot from 2022-09-28 17-11-43

Adds a click to copy button to code samples that don't use the Prism
highlighter.
@geriom
Copy link
Collaborator Author

geriom commented Oct 6, 2022

I'm going to merge this to include it in the release. I don't foresee any problems, but we can always roll it back in a revision release if there's a conflict.

@chalin
Copy link
Collaborator

chalin commented Oct 8, 2022

This implementation requires the latest version of Popper. I ran a grep on the whole website and couldn't find any other Popper instances. So it seems updating the Popper library won't affect anything.

There is an issue with BS. For details, see #1264.

@chalin
Copy link
Collaborator

chalin commented Oct 8, 2022

If / once this makes it into a published release, maybe it would be good to mention this wonderful new feature in the changelog? WDYT @geriom?

geriom added a commit to geriom/docsy that referenced this pull request Feb 27, 2023
Refactor of google#1245, Bootstrap5-compatible code.
geriom added a commit to geriom/docsy that referenced this pull request Feb 27, 2023
Refactor of google#1245, Bootstrap5-compatible code.
geriom added a commit to geriom/docsy that referenced this pull request Feb 28, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
geriom added a commit to geriom/docsy that referenced this pull request Feb 28, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
geriom added a commit to geriom/docsy that referenced this pull request Feb 28, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
geriom added a commit to geriom/docsy that referenced this pull request Mar 6, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
chalin pushed a commit to geriom/docsy that referenced this pull request May 31, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants