[Community Tutorials] Studying Land Surface Temperature in Uganda #51
Conversation
hiyer09
changed the title
gino-m
changed the title
There was a problem hiding this comment.
Thanks for the pull request!
Some comments to get the review process started:
Apologies that some of my comments are brief. If @gino-m has comments, please take his preferences over mine.
- Remove all trailing whitespace from the md and code. e.g.
perl -pi -e 's/\s+\n/\n/g' index.md - Please include the JavaScript code so I can comment directly on it. Comments from the code:
- The code should be able to stand alone from the doc. It just needs a bit more work to do that
- For the first usage: LST → Land Surface Temperature (LST)
- For comments, use consistent capitalization, spacing.
- Please convert the fusion tables asset to an Earth Engine asset or use an existing public asset
- The filterdate comment says 1 year, so using
date.advance(1, 'year')would be more obvious - For the modLSTday.map function:
- Please break the steps up and add some comments.
- Magic numbers are hard to follow. What is the 0.02? What should I look for in https://en.wikipedia.org/wiki/Kelvin ?
- Comment on why the copyProperties
- Please explain why this needs to take a mean of system:time_start in ui.Chart.image.series
- Please cleanup the palette. Use ['name1', 'name2', ...] . I prefer color names if at all possible. Names can be had here:
https://gist.github.com/schwehr/3d72e09263e2341167b12f619ca5d4b2
|
@schwehr Thanks for reviewing. When ready please resolve all outstanding comments and assign back to me. |
Hi Gino, Kurt, thanks for your message. I responded to Kurt's comments last week and thought I requested Gino to re-review but maybe it didn't work. I tried to figure out how to assign back to Gino, but it looks like I don't have permission (the option with checkboxes and assigning doesn't appear for me). Hari |
|
Hi @hiyer09, Apologies for the slow review. I was out sick most of last week. |
There was a problem hiding this comment.
My apologies for the delay and the back and forth - I'm really looking forward to publishing this tutorial, I think it will help a lot of EE users!
I've added a few editorial nits here and there but overall looks great. Please "Resolve" all comments once ready and ping the thread and we can prepare for final publication. Thanks again and thanks @schwehr for the review!
|
@hiyer09 Out of curiosity, are you editing these files via the GitHub Desktop client for Windows? There are some Windows-based line endings in the |
@gino-m Hi Gino, I am editing the markdown file on Github's web interface in chrome. For the javascript file I copy/pasted code from Earth Engine into notepad in windows 10, and then changed the extension on Github. Is there a better way to manage the javascript code? |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
|
@googlebot I consent |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@hiyer09 - congratulations - your tutorial has been merged! It should be published tomorrow. I'll ping you here with the URL when it is up. Do you have a Twitter account? I'd like to announce this tutorial in a tweet and tag you. If you'd prefer it be more anonymous, I'll not tag you. Please let me know. Well done! |
|
Hi Justin-
Awesome! Thanks, please do let me know when it's live, I can share with my
networks. My Twitter handle is @hiyer_epi.
Appreciate the feedback from you, Gino, and Kurt and the crash course in
managing code updates on GitHub. Good learning experience!
Best,
Hari
…On Tue, Oct 22, 2019 at 6:57 PM Justin Braaten ***@***.***> wrote:
@hiyer09 <https://github.com/hiyer09> - congratulations - your tutorial
has been merged! It should be published tomorrow. I'll ping you here with
the URL when it is up.
Do you have a Twitter account? I'd like to announce this tutorial in a
tweet and tag you. If you'd prefer it be more anonymous, I'll not tag you.
Please let me know.
Well done!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AJVBCMKOPMX36BXUBNONCP3QP6APJA5CNFSM4I42XSO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7PFZQ#issuecomment-545190630>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJVBCMO5AMP7MRNUY4WHF5LQP6APJANCNFSM4I42XSOQ>
.
|
|
@hiyer09 - your tutorial is live! 🎉 |
|
Oh awesome, thanks so much!
…On Wed, Oct 23, 2019, 5:09 PM Justin Braaten ***@***.***> wrote:
@hiyer09 <https://github.com/hiyer09> - your tutorial is live! 🎉
https://developers.google.com/earth-engine/tutorials/community/ph-ug-temp
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AJVBCMIGQP646QJBCP7BU5DQQC4QNA5CNFSM4I42XSO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECC4I5A#issuecomment-545637492>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJVBCMKTO6PBXEX7ITZBF3LQQC4QNANCNFSM4I42XSOQ>
.
|
Congratulations Hari, beautiful work! |
This is a tutorial to describe land surface temperature using data from Uganda. I initially submitted with another tutorial (patch-1) but closed that review request.