From c76f797c78c70b34b200ffe185b943675d09b409 Mon Sep 17 00:00:00 2001 From: ghm Date: Wed, 3 May 2023 09:03:43 -0700 Subject: [PATCH] Mass reformat ErrorProne sources. PiperOrigin-RevId: 529106074 --- ...mFragmentNotInstantiableNegativeCases.java | 4 +- ...mFragmentNotInstantiablePositiveCases.java | 4 +- .../FragmentNotInstantiableNegativeCases.java | 4 +- .../FragmentNotInstantiablePositiveCases.java | 4 +- .../HardCodedSdCardPathNegativeCases.java | 4 +- .../HardCodedSdCardPathPositiveCases.java | 4 +- .../ParcelableCreatorNegativeCases.java | 4 +- .../ParcelableCreatorPositiveCases.java | 4 +- ...ersectReturnValueIgnoredNegativeCases.java | 4 +- ...ersectReturnValueIgnoredPositiveCases.java | 4 +- ...loggerRedundantIsEnabledNegativeCases.java | 4 +- ...undantIsEnabledPositiveCases_expected.java | 4 +- .../AssistedInjectScopingNegativeCases.java | 4 +- .../AssistedInjectScopingPositiveCases.java | 4 +- .../AssistedParametersNegativeCases.java | 4 +- .../AssistedParametersPositiveCases.java | 12 +--- .../InjectOnFinalFieldNegativeCases.java | 4 +- .../InjectOnFinalFieldPositiveCases.java | 4 +- ...desGuiceInjectableMethodNegativeCases.java | 4 +- ...desGuiceInjectableMethodPositiveCases.java | 4 +- ...desJavaxInjectableMethodNegativeCases.java | 4 +- ...desJavaxInjectableMethodPositiveCases.java | 6 +- ...tAndInjectOnConstructorsNegativeCases.java | 4 +- ...tAndInjectOnConstructorsPositiveCases.java | 4 +- ...dInjectOnSameConstructorNegativeCases.java | 4 +- ...dInjectOnSameConstructorPositiveCases.java | 4 +- .../CloseableProvidesNegativeCases.java | 4 +- .../CloseableProvidesPositiveCases.java | 4 +- ...etingOnScopingAnnotationNegativeCases.java | 4 +- ...etingOnScopingAnnotationPositiveCases.java | 4 +- ...axInjectOnAbstractMethodNegativeCases.java | 4 +- ...axInjectOnAbstractMethodPositiveCases.java | 4 +- .../JavaxInjectOnFinalFieldNegativeCases.java | 4 +- ...OneInjectableConstructorNegativeCases.java | 4 +- ...OneInjectableConstructorPositiveCases.java | 4 +- .../MoreThanOneQualifierNegativeCases.java | 4 +- .../MoreThanOneQualifierPositiveCases.java | 4 +- ...neScopeAnnotationOnClassNegativeCases.java | 4 +- ...neScopeAnnotationOnClassPositiveCases.java | 4 +- ...lifierAndScopeAnnotationNegativeCases.java | 4 +- ...lifierAndScopeAnnotationPositiveCases.java | 4 +- ...ifierAnnotationRetentionNegativeCases.java | 4 +- ...ifierAnnotationRetentionPositiveCases.java | 4 +- .../testdata/ArrayEqualsNegativeCases.java | 4 +- .../testdata/ArrayEqualsPositiveCases.java | 4 +- .../testdata/ArrayHashCodeNegativeCases.java | 4 +- .../testdata/ArrayHashCodePositiveCases.java | 4 +- ...StringCompoundAssignmentNegativeCases.java | 4 +- ...StringCompoundAssignmentPositiveCases.java | 4 +- ...rayToStringConcatenationNegativeCases.java | 4 +- ...rayToStringConcatenationPositiveCases.java | 4 +- .../testdata/ArrayToStringNegativeCases.java | 4 +- .../testdata/ArrayToStringPositiveCases.java | 4 +- .../testdata/AssertFalseNegativeCases.java | 4 +- .../testdata/AssertFalsePositiveCases.java | 4 +- .../testdata/BadComparableNegativeCases.java | 4 +- .../testdata/BadComparablePositiveCases.java | 4 +- .../testdata/BadImportPositiveCases.java | 2 +- .../testdata/BadShiftAmountNegativeCases.java | 4 +- .../testdata/BadShiftAmountPositiveCases.java | 4 +- ...nedAssertionLosesContextNegativeCases.java | 4 +- ...nedAssertionLosesContextPositiveCases.java | 4 +- ...structorIgnoresParameterNegativeCases.java | 4 +- ...structorIgnoresParameterPositiveCases.java | 4 +- .../CheckReturnValueNegativeCases.java | 4 +- .../CheckReturnValuePositiveCases.java | 4 +- .../ClassCanBeStaticNegativeCases.java | 4 +- .../ClassCanBeStaticPositiveCase1.java | 4 +- .../ClassCanBeStaticPositiveCase2.java | 4 +- .../ClassCanBeStaticPositiveCase3.java | 4 +- ...tionToArraySafeParameterNegativeCases.java | 4 +- ...tionToArraySafeParameterPositiveCases.java | 4 +- ...llectorShouldNotUseStateNegativeCases.java | 4 +- ...llectorShouldNotUseStatePositiveCases.java | 4 +- .../DeadExceptionTestingNegativeCases.java | 4 +- .../testdata/DepAnnNegativeCase1.java | 28 ++++++-- .../testdata/DepAnnNegativeCase2.java | 12 +++- .../testdata/DepAnnPositiveCases.java | 24 +++++-- .../testdata/EmptyCatchNegativeCases.java | 4 +- .../testdata/EmptyCatchPositiveCases.java | 4 +- .../EmptyIfStatementNegativeCases.java | 16 +++-- .../EqualsIncompatibleTypeNegativeCases.java | 4 +- .../EqualsIncompatibleTypePositiveCases.java | 4 +- .../testdata/EqualsNaNNegativeCases.java | 4 +- .../testdata/EqualsNaNPositiveCases.java | 4 +- .../testdata/FinallyNegativeCase1.java | 4 +- .../testdata/FinallyNegativeCase2.java | 4 +- .../testdata/FinallyPositiveCase2.java | 64 +++++++++---------- ...FutureReturnValueIgnoredPositiveCases.java | 4 +- ...dNotBeUsedInEqualsMethodNegativeCases.java | 4 +- ...dNotBeUsedInEqualsMethodPositiveCases.java | 4 +- ...entAssertionWithChainingNegativeCases.java | 4 +- ...entAssertionWithChainingPositiveCases.java | 4 +- ...rementInForLoopAndHeaderPositiveCases.java | 4 +- .../InsecureCipherModePositiveCases.java | 4 +- .../InvalidPatternSyntaxNegativeCases.java | 4 +- .../InvalidPatternSyntaxPositiveCases.java | 4 +- .../IterableAndIteratorNegativeCases.java | 4 +- .../IterableAndIteratorPositiveCases.java | 4 +- .../JUnit3TestNotRunNegativeCase1.java | 4 +- .../JUnit3TestNotRunNegativeCase2.java | 2 +- .../JUnit3TestNotRunPositiveCases.java | 4 +- ...t4SetUpNotRunPositiveCaseCustomBefore.java | 7 +- ...TearDownNotRunPositiveCaseCustomAfter.java | 7 +- .../JUnit4TestNotRunNegativeCase3.java | 4 +- .../JUnit4TestNotRunPositiveCase1.java | 4 +- ...ngLiteralLowerCaseSuffixPositiveCase2.java | 6 +- .../testdata/MissingFailNegativeCases.java | 6 +- .../testdata/MissingFailPositiveCases.java | 6 +- ...lectionInEnhancedForLoopNegativeCases.java | 4 +- ...lectionInEnhancedForLoopPositiveCases.java | 4 +- ...SourceCollectionInStreamPositiveCases.java | 3 +- ...yingCollectionWithItselfNegativeCases.java | 4 +- ...yingCollectionWithItselfPositiveCases.java | 4 +- ...arallelOrSequentialCallsPositiveCases.java | 4 +- ...SequentialCallsPositiveCases_expected.java | 4 +- ...aryOperatorsInMethodCallNegativeCases.java | 4 +- ...aryOperatorsInMethodCallPositiveCases.java | 4 +- ...stedInstanceOfConditionsNegativeCases.java | 9 ++- .../NoAllocationCheckerNegativeCases.java | 4 +- .../NoAllocationCheckerPositiveCases.java | 4 +- .../NonRuntimeAnnotationNegativeCases.java | 4 +- .../NonRuntimeAnnotationPositiveCases.java | 4 +- .../NullablePrimitiveNegativeCases.java | 4 +- .../testdata/ObjectToStringNegativeCases.java | 4 +- .../testdata/ObjectToStringPositiveCases.java | 4 +- ...verrideThrowableToStringNegativeCases.java | 4 +- ...verrideThrowableToStringPositiveCases.java | 4 +- ...rowableToStringPositiveCases_expected.java | 4 +- .../testdata/OverridesNegativeCase1.java | 4 +- .../testdata/OverridesNegativeCase2.java | 4 +- .../testdata/OverridesNegativeCase3.java | 4 +- .../testdata/OverridesPositiveCase1.java | 51 ++++++++------- .../testdata/OverridesPositiveCase2.java | 8 +-- .../testdata/OverridesPositiveCase3.java | 8 +-- .../testdata/OverridesPositiveCase5.java | 5 +- ...rayPassedToVarargsMethodNegativeCases.java | 4 +- ...rayPassedToVarargsMethodPositiveCases.java | 4 +- .../ReturnValueIgnoredNegativeCases.java | 4 +- .../ReturnValueIgnoredPositiveCases.java | 4 +- .../RxReturnValueIgnoredNegativeCases.java | 4 +- .../RxReturnValueIgnoredPositiveCases.java | 4 +- .../SelfEqualsGuavaNegativeCases.java | 4 +- .../testdata/SelfEqualsGuavaPositiveCase.java | 4 +- ...eGreaterThanOrEqualsZeroNegativeCases.java | 4 +- ...eGreaterThanOrEqualsZeroPositiveCases.java | 4 +- ...QualifiedUsingExpressionNegativeCases.java | 4 +- ...QualifiedUsingExpressionPositiveCase1.java | 4 +- ...QualifiedUsingExpressionPositiveCase2.java | 4 +- ...tringBuilderInitWithCharNegativeCases.java | 4 +- ...tringBuilderInitWithCharPositiveCases.java | 4 +- ...ppressWarningsDeprecatedPositiveCases.java | 6 +- .../testdata/SwigMemoryLeakNegativeCases.java | 4 +- .../testdata/SwigMemoryLeakPositiveCases.java | 4 +- .../testdata/ThreadJoinLoopNegativeCases.java | 4 +- .../testdata/ThreadJoinLoopPositiveCases.java | 8 ++- .../ThreadJoinLoopPositiveCases_expected.java | 4 +- ...ncheckedKnownCheckedTestNegativeCases.java | 4 +- ...ncheckedKnownCheckedTestPositiveCases.java | 4 +- ...ThrowsUncheckedExceptionNegativeCases.java | 4 +- ...ThrowsUncheckedExceptionPositiveCases.java | 4 +- .../TryFailThrowableNegativeCases.java | 4 +- .../TryFailThrowablePositiveCases.java | 4 +- .../UngroupedOverloadsNegativeCases.java | 4 +- ...groupedOverloadsPositiveCasesCovering.java | 4 +- ...loadsPositiveCasesCoveringOnlyOnFirst.java | 4 +- ...upedOverloadsPositiveCasesInterleaved.java | 4 +- ...groupedOverloadsPositiveCasesMultiple.java | 4 +- ...UngroupedOverloadsPositiveCasesSingle.java | 4 +- ...OverloadsRefactoringComments_expected.java | 4 +- ...rloadsRefactoringInterleaved_expected.java | 4 +- ...OverloadsRefactoringMultiple_expected.java | 4 +- ...ecessaryBoxedAssignmentCases_expected.java | 4 +- .../testdata/WaitNotInLoopPositiveCases.java | 4 +- .../TimeUnitMismatchNegativeCases.java | 4 +- .../TimeUnitMismatchPositiveCases.java | 4 +- .../testdata/SuppressLintNegativeCases.java | 3 +- .../SuppressWarningsNegativeCases.java | 3 +- 178 files changed, 631 insertions(+), 287 deletions(-) diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiableNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiableNegativeCases.java index fc626c1b190..39030c42703 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiableNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiableNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.android.testdata; -/** @author jasonlong@google.com (Jason Long) */ +/** + * @author jasonlong@google.com (Jason Long) + */ public class CustomFragmentNotInstantiableNegativeCases { public static class NotAFragment1 { public NotAFragment1(int x) {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiablePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiablePositiveCases.java index c6d143a485f..6e1c506262d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiablePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/CustomFragmentNotInstantiablePositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.android.testdata; -/** @author jasonlong@google.com (Jason Long) */ +/** + * @author jasonlong@google.com (Jason Long) + */ public class CustomFragmentNotInstantiablePositiveCases { // BUG: Diagnostic contains: public static class PrivateFragment extends CustomFragment { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiableNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiableNegativeCases.java index 5aeada3d316..82c485b0edf 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiableNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiableNegativeCases.java @@ -18,7 +18,9 @@ import android.app.Fragment; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class FragmentNotInstantiableNegativeCases { public static class NotAFragment1 { public NotAFragment1(int x) {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiablePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiablePositiveCases.java index 9e3ad263e71..71c99dc59ba 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiablePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/FragmentNotInstantiablePositiveCases.java @@ -18,7 +18,9 @@ import android.app.Fragment; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class FragmentNotInstantiablePositiveCases { // BUG: Diagnostic contains: public static class PrivateFragment extends Fragment { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathNegativeCases.java index 696983b89cc..272a38460fe 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.android.testdata; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class HardCodedSdCardPathNegativeCases { static final String PATH1 = "/home/sdcard"; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathPositiveCases.java index 57d26f6c5ff..1ed96e9c060 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/HardCodedSdCardPathPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.android.testdata; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class HardCodedSdCardPathPositiveCases { // BUG: Diagnostic contains: Environment static final String PATH1 = "/sdcard"; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorNegativeCases.java index 61e28fe9809..44665867690 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorNegativeCases.java @@ -20,7 +20,9 @@ import android.os.Parcelable; import android.os.Parcelable.ClassLoaderCreator; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class ParcelableCreatorNegativeCases { public abstract static class PublicAbstractParcelableClass implements Parcelable { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorPositiveCases.java index cf06aa43854..b5fd63b40ab 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/ParcelableCreatorPositiveCases.java @@ -19,7 +19,9 @@ import android.os.Parcel; import android.os.Parcelable; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class ParcelableCreatorPositiveCases { // BUG: Diagnostic contains: ParcelableCreator diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredNegativeCases.java index 8b58b6022ff..0754c359ef3 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredNegativeCases.java @@ -18,7 +18,9 @@ import android.graphics.Rect; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class RectIntersectReturnValueIgnoredNegativeCases { boolean checkSimpleCall(Rect rect, int aLeft, int aTop, int aRight, int aBottom) { return rect.intersect(aLeft, aTop, aRight, aBottom); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredPositiveCases.java index c3bac74a6ac..e359147a555 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/testdata/RectIntersectReturnValueIgnoredPositiveCases.java @@ -18,7 +18,9 @@ import android.graphics.Rect; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class RectIntersectReturnValueIgnoredPositiveCases { void checkSimpleCall(Rect rect, int aLeft, int aTop, int aRight, int aBottom) { // BUG: Diagnostic contains: Return value of android.graphics.Rect.intersect() must be checked diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledNegativeCases.java index aba4bb9ec4d..0d9c6aaf96f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledNegativeCases.java @@ -21,7 +21,9 @@ import java.util.List; import java.util.Map; -/** @author mariasam@google.com (Maria Sam) */ +/** + * @author mariasam@google.com (Maria Sam) + */ public class FloggerRedundantIsEnabledNegativeCases { public void basicCase(FluentLogger logger) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledPositiveCases_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledPositiveCases_expected.java index 02064dcc2c5..21113e2e017 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledPositiveCases_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/flogger/testdata/FloggerRedundantIsEnabledPositiveCases_expected.java @@ -18,7 +18,9 @@ import com.google.common.flogger.FluentLogger; -/** @author mariasam@google.com (Maria Sam) */ +/** + * @author mariasam@google.com (Maria Sam) + */ class FloggerRedundantIsEnabledPositiveCases { public void basicCase(FluentLogger logger) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingNegativeCases.java index 38ef2528959..90496203f01 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingNegativeCases.java @@ -20,7 +20,9 @@ import com.google.inject.assistedinject.Assisted; import com.google.inject.assistedinject.AssistedInject; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class AssistedInjectScopingNegativeCases { /** Class is not assisted and has no scoping annotation. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingPositiveCases.java index 0af936aa245..82c0a6cf155 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedInjectScopingPositiveCases.java @@ -21,7 +21,9 @@ import com.google.inject.assistedinject.AssistedInject; import com.google.inject.servlet.RequestScoped; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class AssistedInjectScopingPositiveCases { // BUG: Diagnostic contains: remove this line diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersNegativeCases.java index 7c56b6fda2f..6a7516049d4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersNegativeCases.java @@ -23,9 +23,7 @@ */ public class AssistedParametersNegativeCases { - /** - * Class has constructor with two @Assisted parameters of different types. - */ + /** Class has constructor with two @Assisted parameters of different types. */ public class TestClass1 { @Inject public TestClass1(@Assisted int x, @Assisted String y, long z) {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersPositiveCases.java index 2fcb727e310..5c704cea5ac 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/AssistedParametersPositiveCases.java @@ -25,9 +25,7 @@ */ public class AssistedParametersPositiveCases { - /** - * Class has constructor with two @Assisted parameters of the same type. - */ + /** Class has constructor with two @Assisted parameters of the same type. */ public class TestClass1 { @Inject // BUG: Diagnostic contains: java.lang.String: x, y @@ -42,18 +40,14 @@ public TestClass1( @Assisted("baz") String z) {} } - /** - * Class has constructor with two @Assisted parameters of the same type and same value. - */ + /** Class has constructor with two @Assisted parameters of the same type and same value. */ public class TestClass2 { @Inject // BUG: Diagnostic contains: int, @Assisted("foo"): x, y public TestClass2(int n, @Assisted("foo") int x, @Assisted("foo") int y, String z) {} } - /** - * Class has constructor with two @Assisted parameters of the same parameterized type. - */ + /** Class has constructor with two @Assisted parameters of the same parameterized type. */ public class TestClass3 { private static final String FOO = "foo"; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldNegativeCases.java index 7411a8eb68c..71a167e7769 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldNegativeCases.java @@ -18,7 +18,9 @@ import com.google.inject.Inject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class InjectOnFinalFieldNegativeCases { /** Class has no final fields or @Inject annotations. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldPositiveCases.java index d2af5b3041e..f75e92e15c8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/InjectOnFinalFieldPositiveCases.java @@ -19,7 +19,9 @@ import com.google.inject.Inject; import javax.annotation.Nullable; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class InjectOnFinalFieldPositiveCases { /** Class has a final injectable(com.google.inject.Inject) field. */ public class TestClass1 { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodNegativeCases.java index 2bcad2912e5..bdd8509bed1 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.inject.guice.testdata; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class OverridesGuiceInjectableMethodNegativeCases { /** Class with a method foo() annotated with @com.google.inject.Inject. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodPositiveCases.java index fd4a94efe2b..abb6e8392d8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesGuiceInjectableMethodPositiveCases.java @@ -21,9 +21,7 @@ */ public class OverridesGuiceInjectableMethodPositiveCases { - /** - * Class with a method foo() annotated with @com.google.inject.Inject. - */ + /** Class with a method foo() annotated with @com.google.inject.Inject. */ public class TestClass1 { @com.google.inject.Inject public void foo() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodNegativeCases.java index 4a058e01854..5be36002b1f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.inject.guice.testdata; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class OverridesJavaxInjectableMethodNegativeCases { /** Class with a method foo() with no annotations. */ public class TestClass1 { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodPositiveCases.java index c378fe72c9c..473bf5917c4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/testdata/OverridesJavaxInjectableMethodPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.inject.guice.testdata; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class OverridesJavaxInjectableMethodPositiveCases { /** Class with foo() */ @@ -41,7 +43,7 @@ public class TestClass2 extends TestClass1 { // BUG: Diagnostic contains: @Inject public void foo() {} } - + /** * Class with a method foo() that is not annotated, but overrides a method that in turn overrides * a method that is annotated with @javax.inject.Inject. diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsNegativeCases.java index 37be0bc9cd0..bbfe6f57973 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsNegativeCases.java @@ -18,7 +18,9 @@ import com.google.inject.assistedinject.AssistedInject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class AssistedInjectAndInjectOnConstructorsNegativeCases { /** Class has a single constructor with no annotation. */ public class TestClass1 { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsPositiveCases.java index ca60b9ee9a4..72620744f69 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnConstructorsPositiveCases.java @@ -18,7 +18,9 @@ import com.google.inject.assistedinject.AssistedInject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class AssistedInjectAndInjectOnConstructorsPositiveCases { /** * Class has a constructor annotated with @javax.inject.Inject and another constructor annotated diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorNegativeCases.java index 87d92cab794..1e11c58a2de 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorNegativeCases.java @@ -18,7 +18,9 @@ import com.google.inject.assistedinject.AssistedInject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class AssistedInjectAndInjectOnSameConstructorNegativeCases { /** Class has a single constructor with no annotation. */ public class TestClass1 { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorPositiveCases.java index 34848ba205c..fe237aa0dd8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/AssistedInjectAndInjectOnSameConstructorPositiveCases.java @@ -18,7 +18,9 @@ import com.google.inject.assistedinject.AssistedInject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class AssistedInjectAndInjectOnSameConstructorPositiveCases { /** Class has a constructor annotated with @javax.inject.Inject and @AssistedInject. */ public class TestClass1 { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesNegativeCases.java index 340926082c6..d57077a3535 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesNegativeCases.java @@ -19,7 +19,9 @@ import com.google.inject.Provides; import javax.inject.Singleton; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class CloseableProvidesNegativeCases { static class DoesNotImplementsClosable { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesPositiveCases.java index 1a04af01152..a0e517d0e41 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/CloseableProvidesPositiveCases.java @@ -22,7 +22,9 @@ import java.nio.charset.StandardCharsets; import javax.inject.Singleton; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class CloseableProvidesPositiveCases { static class ImplementsClosable implements Closeable { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationNegativeCases.java index f93dc993fbd..597a258313f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationNegativeCases.java @@ -25,7 +25,9 @@ import java.lang.annotation.Target; import javax.inject.Scope; -/** @author sgoldfeder@google.com(Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com(Steven Goldfeder) + */ public class InvalidTargetingOnScopingAnnotationNegativeCases { /** A scoping annotation with no specified target. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationPositiveCases.java index 419c48c34bb..77f124c5ab7 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/InvalidTargetingOnScopingAnnotationPositiveCases.java @@ -28,7 +28,9 @@ import java.lang.annotation.Target; import javax.inject.Scope; -/** @author sgoldfeder@google.com(Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com(Steven Goldfeder) + */ public class InvalidTargetingOnScopingAnnotationPositiveCases { /** Scoping excludes METHOD */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodNegativeCases.java index fad10ca2d00..05afa16282b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodNegativeCases.java @@ -18,7 +18,9 @@ import javax.inject.Inject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class JavaxInjectOnAbstractMethodNegativeCases { /** Concrete class has no methods or annotations. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodPositiveCases.java index 56cfac01257..9afd3df9eff 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnAbstractMethodPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.inject.testdata; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class JavaxInjectOnAbstractMethodPositiveCases { /** Abstract class has an injectable(javax.inject.Inject) abstract method. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnFinalFieldNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnFinalFieldNegativeCases.java index ccb99690caf..bdbfe7ccb6a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnFinalFieldNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/JavaxInjectOnFinalFieldNegativeCases.java @@ -18,7 +18,9 @@ import javax.inject.Inject; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class JavaxInjectOnFinalFieldNegativeCases { /** Class has no final fields or @Inject annotations. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorNegativeCases.java index 89bd51a4697..79864785fa5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorNegativeCases.java @@ -18,7 +18,9 @@ import com.google.inject.Inject; -/** @author sgoldfeder@google.com(Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com(Steven Goldfeder) + */ public class MoreThanOneInjectableConstructorNegativeCases { /** Class has a single non-injectable constructor. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorPositiveCases.java index 95e053ea3ed..c8fe6ad01ec 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneInjectableConstructorPositiveCases.java @@ -19,7 +19,9 @@ import com.google.inject.Inject; import java.beans.ConstructorProperties; -/** @author sgoldfeder@google.com(Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com(Steven Goldfeder) + */ public class MoreThanOneInjectableConstructorPositiveCases { /** Class has 2 constructors, both are injectable */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierNegativeCases.java index 0997b6f5f5e..dc2a7c4861d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierNegativeCases.java @@ -22,7 +22,9 @@ import java.lang.annotation.Retention; import javax.inject.Qualifier; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class MoreThanOneQualifierNegativeCases { /** A class in with no annotations on any of its members. */ public class TestClass1 { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierPositiveCases.java index d3acbd85e75..e6524c92f39 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneQualifierPositiveCases.java @@ -22,7 +22,9 @@ import java.lang.annotation.Retention; import javax.inject.Qualifier; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class MoreThanOneQualifierPositiveCases { /** diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassNegativeCases.java index a48068fa0c9..e6368a37dae 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassNegativeCases.java @@ -24,7 +24,9 @@ import dagger.producers.ProductionComponent; import dagger.producers.ProductionSubcomponent; -/** @author sgoldfeder@google.com(Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com(Steven Goldfeder) + */ public class MoreThanOneScopeAnnotationOnClassNegativeCases { /** Class has no annotation. */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassPositiveCases.java index 462a4acedca..3be1e172487 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/MoreThanOneScopeAnnotationOnClassPositiveCases.java @@ -20,7 +20,9 @@ import com.google.inject.servlet.SessionScoped; import javax.inject.Scope; -/** @author sgoldfeder@google.com(Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com(Steven Goldfeder) + */ public class MoreThanOneScopeAnnotationOnClassPositiveCases { /** Class has two scope annotations */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationNegativeCases.java index 76d7e64e973..ad1e294f689 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.inject.testdata; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class OverlappingQualifierAndScopeAnnotationNegativeCases { @javax.inject.Scope diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationPositiveCases.java index 2575457cf6f..cf8d31178d6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/OverlappingQualifierAndScopeAnnotationPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.inject.testdata; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class OverlappingQualifierAndScopeAnnotationPositiveCases { @javax.inject.Scope diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionNegativeCases.java index 24b5452e15a..aef6a2ca962 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionNegativeCases.java @@ -28,7 +28,9 @@ import javax.inject.Qualifier; import javax.inject.Scope; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class ScopeOrQualifierAnnotationRetentionNegativeCases { /** A scoping (@Scope) annotation with runtime retention */ @Scope diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionPositiveCases.java index 752541a5384..4a6da5a0291 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/testdata/ScopeOrQualifierAnnotationRetentionPositiveCases.java @@ -27,7 +27,9 @@ import javax.inject.Qualifier; import javax.inject.Scope; -/** @author sgoldfeder@google.com (Steven Goldfeder) */ +/** + * @author sgoldfeder@google.com (Steven Goldfeder) + */ public class ScopeOrQualifierAnnotationRetentionPositiveCases { /** A scoping (@Scope) annotation with SOURCE retention */ @Scope diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsNegativeCases.java index c384a0e629e..0e95922b81b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsNegativeCases.java @@ -18,7 +18,9 @@ import com.google.common.base.Objects; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class ArrayEqualsNegativeCases { public void neitherArray() { Object a = new Object(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsPositiveCases.java index 37faaf08466..7b47c238ff8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayEqualsPositiveCases.java @@ -18,7 +18,9 @@ import com.google.common.base.Objects; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class ArrayEqualsPositiveCases { public void intArray() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodeNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodeNegativeCases.java index a7b0ae790be..2f5b85d46de 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodeNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodeNegativeCases.java @@ -18,7 +18,9 @@ import com.google.common.base.Objects; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class ArrayHashCodeNegativeCases { private Object[] objArray = {1, 2, 3}; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodePositiveCases.java index 2e826fb5d7e..4b51c3d075d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayHashCodePositiveCases.java @@ -18,7 +18,9 @@ import com.google.common.base.Objects; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class ArrayHashCodePositiveCases { private Object[] objArray = {1, 2, 3}; private String[] stringArray = {"1", "2", "3"}; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentNegativeCases.java index 778e698eed3..34ef562111e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author adgar@google.com (Mike Edgar) */ +/** + * @author adgar@google.com (Mike Edgar) + */ public class ArrayToStringCompoundAssignmentNegativeCases { public void concatenateCompoundAssign_object() { Object a = new Object(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentPositiveCases.java index 6b5e05e3c96..ea9c1c4a970 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringCompoundAssignmentPositiveCases.java @@ -18,7 +18,9 @@ import java.util.*; -/** @author adgar@google.com (Mike Edgar) */ +/** + * @author adgar@google.com (Mike Edgar) + */ public class ArrayToStringCompoundAssignmentPositiveCases { private static final int[] a = {1, 2, 3}; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationNegativeCases.java index 28fd289cbb8..e318151a06a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author adgar@google.com (Mike Edgar) */ +/** + * @author adgar@google.com (Mike Edgar) + */ public class ArrayToStringConcatenationNegativeCases { public void notArray() { Object a = new Object(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationPositiveCases.java index 99a1508bf8f..df777c64f73 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringConcatenationPositiveCases.java @@ -18,7 +18,9 @@ import java.util.*; -/** @author adgar@google.com (Mike Edgar) */ +/** + * @author adgar@google.com (Mike Edgar) + */ public class ArrayToStringConcatenationPositiveCases { private static final int[] a = {1, 2, 3}; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringNegativeCases.java index 5b0f8d6e1ec..6893f048856 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringNegativeCases.java @@ -18,7 +18,9 @@ import java.util.*; -/** @author adgar@google.com (Mike Edgar) */ +/** + * @author adgar@google.com (Mike Edgar) + */ public class ArrayToStringNegativeCases { public void objectEquals() { Object a = new Object(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringPositiveCases.java index 034a4c90234..10ce413ae29 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ArrayToStringPositiveCases.java @@ -18,7 +18,9 @@ import java.util.*; -/** @author adgar@google.com (Mike Edgar) */ +/** + * @author adgar@google.com (Mike Edgar) + */ public class ArrayToStringPositiveCases { public void intArray() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalseNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalseNegativeCases.java index 07753530195..26694d22837 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalseNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalseNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author sebastian.h.monte@gmail.com (Sebastian Monte) */ +/** + * @author sebastian.h.monte@gmail.com (Sebastian Monte) + */ public class AssertFalseNegativeCases { public void assertTrue() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalsePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalsePositiveCases.java index f2d341e4eea..1794830af2c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalsePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/AssertFalsePositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author sebastian.h.monte@gmail.com (Sebastian Monte) */ +/** + * @author sebastian.h.monte@gmail.com (Sebastian Monte) + */ public class AssertFalsePositiveCases { public void assertFalse() { // BUG: Diagnostic contains: throw new AssertionError() diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparableNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparableNegativeCases.java index 34b9399575b..7d506ef259e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparableNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparableNegativeCases.java @@ -18,7 +18,9 @@ import java.util.Comparator; -/** @author irogers@google.com (Ian Rogers) */ +/** + * @author irogers@google.com (Ian Rogers) + */ public class BadComparableNegativeCases { // The corrected cases of the PositiveCases test. static class ComparableTest implements Comparable { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositiveCases.java index 776d2b04a42..6ff360bf3e7 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositiveCases.java @@ -19,7 +19,9 @@ import java.io.File; import java.util.Comparator; -/** @author irogers@google.com (Ian Rogers) */ +/** + * @author irogers@google.com (Ian Rogers) + */ public class BadComparablePositiveCases { static class ComparableTest implements Comparable { private final long value = 0; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadImportPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadImportPositiveCases.java index f2b6fd95482..491dcf86594 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadImportPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadImportPositiveCases.java @@ -40,7 +40,7 @@ public void variableDeclarationsNestedGenerics() { } @Nullable - Builder<@Nullable Builder<@Nullable String>> parameterizedWithTypeUseAnnotationMethod() { + Builder<@Nullable Builder<@Nullable String>> parameterizedWithTypeUseAnnotationMethod() { return null; } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountNegativeCases.java index 20457819734..c1e86333027 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author Bill Pugh (bill.pugh@gmail.com) */ +/** + * @author Bill Pugh (bill.pugh@gmail.com) + */ public class BadShiftAmountNegativeCases { public void foo() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountPositiveCases.java index 67e596c6b71..deacbccdbf6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadShiftAmountPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author Bill Pugh (bill.pugh@gmail.com) */ +/** + * @author Bill Pugh (bill.pugh@gmail.com) + */ public class BadShiftAmountPositiveCases { public void foo() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextNegativeCases.java index 7b2f4926e4d..c35eea5d4d1 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextNegativeCases.java @@ -22,7 +22,9 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.Subject; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ChainedAssertionLosesContextNegativeCases { static final class FooSubject extends Subject { private final Foo actual; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextPositiveCases.java index e13eae6ad51..2307edaf4ba 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainedAssertionLosesContextPositiveCases.java @@ -24,7 +24,9 @@ import com.google.common.truth.Subject; import com.google.common.truth.Truth; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ChainedAssertionLosesContextPositiveCases { static final class FooSubject extends Subject { private final Foo actual; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterNegativeCases.java index 5de1cc3217d..c113286e895 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterNegativeCases.java @@ -18,7 +18,9 @@ import java.io.File; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ChainingConstructorIgnoresParameterNegativeCases { static class ImplicitThisCall { ImplicitThisCall() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterPositiveCases.java index 3a237c15bb8..e88f19632ee 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ChainingConstructorIgnoresParameterPositiveCases.java @@ -18,7 +18,9 @@ import static com.google.errorprone.bugpatterns.testdata.ChainingConstructorIgnoresParameterPositiveCases.Location.TEST_TARGET; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ChainingConstructorIgnoresParameterPositiveCases { static class MissileLauncher { MissileLauncher(Location target, boolean askForConfirmation) {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValueNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValueNegativeCases.java index 18c872fbb53..7973b1ee4a5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValueNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValueNegativeCases.java @@ -19,7 +19,9 @@ import com.google.errorprone.annotations.CheckReturnValue; import java.util.function.Supplier; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class CheckReturnValueNegativeCases { public void test1() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValuePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValuePositiveCases.java index ef76f2b4fae..ec4f808b92a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValuePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CheckReturnValuePositiveCases.java @@ -19,7 +19,9 @@ import com.google.errorprone.annotations.CheckReturnValue; import org.junit.rules.ExpectedException; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class CheckReturnValuePositiveCases { IntValue intValue = new IntValue(0); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticNegativeCases.java index fe3bfe7a77a..7b9ab57e4c2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author alexloh@google.com (Alex Loh) */ +/** + * @author alexloh@google.com (Alex Loh) + */ public class ClassCanBeStaticNegativeCases { int outerVar; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase1.java index d85ab018ca2..5711455f1d5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase1.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author alexloh@google.com (Alex Loh) */ +/** + * @author alexloh@google.com (Alex Loh) + */ public class ClassCanBeStaticPositiveCase1 { int outerVar; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase2.java index d9640905d74..626c07e3194 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase2.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author alexloh@google.com (Alex Loh) */ +/** + * @author alexloh@google.com (Alex Loh) + */ public class ClassCanBeStaticPositiveCase2 { int outerVar1; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase3.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase3.java index 0c218cc27a6..9a222b61d25 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase3.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ClassCanBeStaticPositiveCase3.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author alexloh@google.com (Alex Loh) */ +/** + * @author alexloh@google.com (Alex Loh) + */ public class ClassCanBeStaticPositiveCase3 { static int outerVar; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterNegativeCases.java index 4bdb9bb89c1..dbcda5316b2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterNegativeCases.java @@ -19,7 +19,9 @@ import java.util.Collection; import java.util.HashSet; -/** @author mariasam@google.com (Maria Sam) on 6/27/17. */ +/** + * @author mariasam@google.com (Maria Sam) on 6/27/17. + */ public class CollectionToArraySafeParameterNegativeCases { private void basicCase() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterPositiveCases.java index 2bae4c922b3..052959d9f77 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectionToArraySafeParameterPositiveCases.java @@ -20,7 +20,9 @@ import java.util.HashSet; import java.util.Set; -/** @author mariasam@google.com (Maria Sam) on 6/27/17. */ +/** + * @author mariasam@google.com (Maria Sam) on 6/27/17. + */ public class CollectionToArraySafeParameterPositiveCases { private static void basicCase() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStateNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStateNegativeCases.java index 5ac940569c2..571dfdad475 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStateNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStateNegativeCases.java @@ -20,7 +20,9 @@ import java.util.function.BiConsumer; import java.util.stream.Collector; -/** @author sulku@google.com (Marsela Sulku) */ +/** + * @author sulku@google.com (Marsela Sulku) + */ public class CollectorShouldNotUseStateNegativeCases { public void test() { Collector.of( diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStatePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStatePositiveCases.java index 0d00431e3d4..494a13bb946 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStatePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/CollectorShouldNotUseStatePositiveCases.java @@ -20,7 +20,9 @@ import java.util.function.BiConsumer; import java.util.stream.Collector; -/** @author sulku@google.com (Marsela Sulku) */ +/** + * @author sulku@google.com (Marsela Sulku) + */ public class CollectorShouldNotUseStatePositiveCases { public void test() { // BUG: Diagnostic contains: Collector.of() should not use state diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DeadExceptionTestingNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DeadExceptionTestingNegativeCases.java index 62f60263a34..a6e6dcf0bd5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DeadExceptionTestingNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DeadExceptionTestingNegativeCases.java @@ -19,7 +19,9 @@ import junit.framework.TestCase; import org.junit.Test; -/** @author alexeagle@google.com (Alex Eagle) */ +/** + * @author alexeagle@google.com (Alex Eagle) + */ public class DeadExceptionTestingNegativeCases extends TestCase { public void testShouldAllowTestingOfExceptionConstructorSideEffects() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase1.java index 67a705b2514..3cbdd1b0662 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase1.java @@ -16,28 +16,40 @@ package com.google.errorprone.bugpatterns.testdata; -/** @deprecated */ +/** + * @deprecated + */ @Deprecated public class DepAnnNegativeCase1 { - /** @deprecated */ + /** + * @deprecated + */ @Deprecated public DepAnnNegativeCase1() {} - /** @deprecated */ + /** + * @deprecated + */ @Deprecated int myField; - /** @deprecated */ + /** + * @deprecated + */ @Deprecated enum Enum { VALUE, } - /** @deprecated */ + /** + * @deprecated + */ @Deprecated interface Interface {} - /** @deprecated */ + /** + * @deprecated + */ @Deprecated public void deprecatedMethood() {} @@ -47,7 +59,9 @@ public void deprecatedMethoodWithoutComment() {} /** deprecated */ public void deprecatedMethodWithMalformedComment() {} - /** @deprecated */ + /** + * @deprecated + */ @SuppressWarnings("dep-ann") public void suppressed() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase2.java index 526887f15b6..0a50c3aca44 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnNegativeCase2.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @deprecated */ +/** + * @deprecated + */ @Deprecated public class DepAnnNegativeCase2 { @@ -24,10 +26,14 @@ abstract class Builder2

{ class SummaryRowKey

{} @Deprecated - /** @deprecated use {@link Selector.Builder#withSummary()} */ + /** + * @deprecated use {@link Selector.Builder#withSummary()} + */ public abstract void withSummaryRowKeys(int summaryRowKeys); - /** @deprecated use {@link Selector.Builder#withSummary()} */ + /** + * @deprecated use {@link Selector.Builder#withSummary()} + */ @Deprecated public abstract void m1(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnPositiveCases.java index c54ed98ebad..2d5644d1df6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DepAnnPositiveCases.java @@ -16,29 +16,41 @@ package com.google.errorprone.bugpatterns.testdata; -/** @deprecated */ +/** + * @deprecated + */ // BUG: Diagnostic contains: @Deprecated public class DepAnnPositiveCases { - /** @deprecated */ + /** + * @deprecated + */ // BUG: Diagnostic contains: @Deprecated public DepAnnPositiveCases() {} - /** @deprecated */ + /** + * @deprecated + */ // BUG: Diagnostic contains: @Deprecated int myField; - /** @deprecated */ + /** + * @deprecated + */ // BUG: Diagnostic contains: @Deprecated enum Enum { VALUE, } - /** @deprecated */ + /** + * @deprecated + */ // BUG: Diagnostic contains: @Deprecated interface Interface {} - /** @deprecated */ + /** + * @deprecated + */ // BUG: Diagnostic contains: @Deprecated public void deprecatedMethood() {} } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchNegativeCases.java index 637302cbac9..b1a733bfea6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchNegativeCases.java @@ -21,7 +21,9 @@ import java.io.FileNotFoundException; import org.junit.Test; -/** @author yuan@ece.toronto.edu (Ding Yuan) */ +/** + * @author yuan@ece.toronto.edu (Ding Yuan) + */ public class EmptyCatchNegativeCases { public void error() throws IllegalArgumentException { throw new IllegalArgumentException("Fake exception."); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchPositiveCases.java index b9f66490055..7cf5252ace4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyCatchPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns; -/** @author yuan@ece.toronto.edu (Ding Yuan) */ +/** + * @author yuan@ece.toronto.edu (Ding Yuan) + */ public class EmptyCatchPositiveCases { public void error() throws IllegalArgumentException { throw new IllegalArgumentException("Fake exception."); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyIfStatementNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyIfStatementNegativeCases.java index 29a939b9117..ee2c5a1db5a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyIfStatementNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EmptyIfStatementNegativeCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class EmptyIfStatementNegativeCases { // just a normal use of if @@ -30,16 +32,20 @@ public static void negativeCase1() { // empty then part but nonempty else public static void negativeCase2() { int i = 0; - if (i == 10) ; + if (i == 10) + ; else System.out.println("not 10"); } // multipart if with non-empty else public static void negativeCase3() { int i = 0; - if (i == 10) ; - else if (i == 11) ; - else if (i == 12) ; + if (i == 10) + ; + else if (i == 11) + ; + else if (i == 12) + ; else System.out.println("not 10, 11, or 12"); } } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypeNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypeNegativeCases.java index eff1bc631e8..5ed93274e84 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypeNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypeNegativeCases.java @@ -21,7 +21,9 @@ import java.util.List; import java.util.Set; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class EqualsIncompatibleTypeNegativeCases { class A { public boolean equals(Object o) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypePositiveCases.java index 3ac8c28b9ac..11acf98107d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsIncompatibleTypePositiveCases.java @@ -21,7 +21,9 @@ import java.util.Map; import java.util.Set; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class EqualsIncompatibleTypePositiveCases { class A {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNNegativeCases.java index e0a4910c3a6..c61702e173b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author lowasser@google.com (Louis Wasserman) */ +/** + * @author lowasser@google.com (Louis Wasserman) + */ public class EqualsNaNNegativeCases { static final boolean NAN_AFTER_MATH = (0.0 / 0.0) == 1.0; static final boolean NORMAL_COMPARISON = 1.0 == 2.0; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNPositiveCases.java index 0e8ceb49269..898dec47f61 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/EqualsNaNPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author lowasser@google.com (Louis Wasserman) */ +/** + * @author lowasser@google.com (Louis Wasserman) + */ public class EqualsNaNPositiveCases { // BUG: Diagnostic contains: Double.isNaN(0.0) diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase1.java index 92387721dd1..91eb1971b70 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase1.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class FinallyNegativeCase1 { public static void test1() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase2.java index f6713e4b791..268da4a2a7d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyNegativeCase2.java @@ -18,7 +18,9 @@ import java.io.IOException; -/** @author cushon@google.com (Liam Miller-Cushon) */ +/** + * @author cushon@google.com (Liam Miller-Cushon) + */ public class FinallyNegativeCase2 { public void test1(boolean flag) { try { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyPositiveCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyPositiveCase2.java index 9dfe22d1d2a..a8c3e2f76e9 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyPositiveCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FinallyPositiveCase2.java @@ -24,106 +24,106 @@ public class FinallyPositiveCase2 { public void completeWithReturn(boolean flag) { try { - + } finally { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: return; } } - + public void completeWithThrow(boolean flag) throws Exception { try { - + } finally { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: throw new Exception(); } } - + public void unreachableThrow(boolean flag) throws Exception { try { - + } finally { if (flag) { - // BUG: Diagnostic contains: - throw new Exception(); + // BUG: Diagnostic contains: + throw new Exception(); } } } - + public void nestedBlocks(int i, boolean flag) throws Exception { try { - + } finally { switch (i) { default: - { - while (flag) { - do { - if (flag) { - } else { - // BUG: Diagnostic contains: - throw new Exception(); - } - } while (flag); + { + while (flag) { + do { + if (flag) { + } else { + // BUG: Diagnostic contains: + throw new Exception(); + } + } while (flag); + } } - } } } } - + public void nestedFinally() throws Exception { try { - + } finally { try { } finally { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: throw new IOException(); } } } - + public void returnFromTryNestedInFinally() { try { } finally { try { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: return; } finally { } } } - + public void returnFromCatchNestedInFinally() { try { } finally { try { } catch (Exception e) { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: return; } finally { } } } - + public void throwUncaughtFromNestedTryInFinally() throws Exception { try { } finally { try { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: throw new Exception(); } finally { } } } - + public void throwFromNestedCatchInFinally() throws Exception { try { } finally { try { } catch (Exception e) { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: throw new Exception(); } finally { } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FutureReturnValueIgnoredPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FutureReturnValueIgnoredPositiveCases.java index 0f1bdd17794..d6ffe165228 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FutureReturnValueIgnoredPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FutureReturnValueIgnoredPositiveCases.java @@ -24,7 +24,9 @@ import java.util.concurrent.Executor; import java.util.concurrent.Future; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class FutureReturnValueIgnoredPositiveCases { IntValue intValue = new IntValue(0); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodNegativeCases.java index 50b46b164d5..5dfc652a1a1 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodNegativeCases.java @@ -17,7 +17,9 @@ import com.google.common.math.DoubleMath; -/** @author sulku@google.com (Marsela Sulku) */ +/** + * @author sulku@google.com (Marsela Sulku) + */ public class FuzzyEqualsShouldNotBeUsedInEqualsMethodNegativeCases { public boolean equals() { return true; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodPositiveCases.java index f0520225d41..84d0d8551f4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/FuzzyEqualsShouldNotBeUsedInEqualsMethodPositiveCases.java @@ -17,7 +17,9 @@ import com.google.common.math.DoubleMath; -/** @author sulku@google.com (Marsela Sulku) */ +/** + * @author sulku@google.com (Marsela Sulku) + */ public class FuzzyEqualsShouldNotBeUsedInEqualsMethodPositiveCases { public boolean equals(Object o) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingNegativeCases.java index 8f05547c781..ab776a94da4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingNegativeCases.java @@ -19,7 +19,9 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.Subject; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ImplementAssertionWithChainingNegativeCases { static final class FooSubject extends Subject { private final Foo actual; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingPositiveCases.java index d1abadb8d67..27ea8c9bb2c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ImplementAssertionWithChainingPositiveCases.java @@ -19,7 +19,9 @@ import com.google.common.truth.FailureMetadata; import com.google.common.truth.Subject; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ImplementAssertionWithChainingPositiveCases { static final class FooSubject extends Subject { private final Foo actual; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IncrementInForLoopAndHeaderPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IncrementInForLoopAndHeaderPositiveCases.java index 18c5a07b0d5..2e7a5e6cd44 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IncrementInForLoopAndHeaderPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IncrementInForLoopAndHeaderPositiveCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author mariasam@google.com (Maria Sam) */ +/** + * @author mariasam@google.com (Maria Sam) + */ public class IncrementInForLoopAndHeaderPositiveCases { public void basicTest() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModePositiveCases.java index c48b3c2bd7f..f69ee48dd56 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InsecureCipherModePositiveCases.java @@ -24,7 +24,9 @@ import javax.crypto.KeyAgreement; import javax.crypto.NoSuchPaddingException; -/** @author avenet@google.com (Arnaud J. Venet) */ +/** + * @author avenet@google.com (Arnaud J. Venet) + */ public class InsecureCipherModePositiveCases { static Cipher defaultAesCipher; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxNegativeCases.java index 04b66396c49..daa7d2dac8e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxNegativeCases.java @@ -18,7 +18,9 @@ import java.util.regex.Pattern; -/** @author mdempsky@google.com (Matthew Dempsky) */ +/** + * @author mdempsky@google.com (Matthew Dempsky) + */ public class InvalidPatternSyntaxNegativeCases { public void foo(String x) { Pattern.compile("t"); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxPositiveCases.java index 2fee32ca3a1..545f6448832 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/InvalidPatternSyntaxPositiveCases.java @@ -18,7 +18,9 @@ import java.util.regex.Pattern; -/** @author mdempsky@google.com (Matthew Dempsky) */ +/** + * @author mdempsky@google.com (Matthew Dempsky) + */ public class InvalidPatternSyntaxPositiveCases { public static final String INVALID = "*"; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorNegativeCases.java index cc25e747ceb..8523c14427a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorNegativeCases.java @@ -18,7 +18,9 @@ import java.util.Iterator; -/** @author jsjeon@google.com (Jinseong Jeon) */ +/** + * @author jsjeon@google.com (Jinseong Jeon) + */ public class IterableAndIteratorNegativeCases { /** Test Node */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorPositiveCases.java index 28999577194..801b45bdab5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/IterableAndIteratorPositiveCases.java @@ -18,7 +18,9 @@ import java.util.Iterator; -/** @author jsjeon@google.com (Jinseong Jeon) */ +/** + * @author jsjeon@google.com (Jinseong Jeon) + */ public class IterableAndIteratorPositiveCases { /** Test Node */ diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase1.java index e50759f48f7..f06a944dfad 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase1.java @@ -20,7 +20,9 @@ import org.junit.Ignore; import org.junit.Test; -/** @author rburny@google.com (Radoslaw Burny) */ +/** + * @author rburny@google.com (Radoslaw Burny) + */ public class JUnit3TestNotRunNegativeCase1 extends TestCase { // correctly spelled diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase2.java index fef30b99890..3d72ff6f5c4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunNegativeCase2.java @@ -28,7 +28,7 @@ @RunWith(JUnit4.class) public class JUnit3TestNotRunNegativeCase2 { - //JUnit4 tests should be ignored, no matter what their names are. + // JUnit4 tests should be ignored, no matter what their names are. @Test public void nameDoesNotStartWithTest() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunPositiveCases.java index 53eeec320d3..4cb41ecc79d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit3TestNotRunPositiveCases.java @@ -18,7 +18,9 @@ import junit.framework.TestCase; -/** @author rburny@google.com (Radoslaw Burny) */ +/** + * @author rburny@google.com (Radoslaw Burny) + */ public class JUnit3TestNotRunPositiveCases extends TestCase { // BUG: Diagnostic contains: JUnit3TestNotRun public static void tesNameStatic() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4SetUpNotRunPositiveCaseCustomBefore.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4SetUpNotRunPositiveCaseCustomBefore.java index 24ec4685e42..9b38b18bb2e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4SetUpNotRunPositiveCaseCustomBefore.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4SetUpNotRunPositiveCaseCustomBefore.java @@ -19,14 +19,13 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; -/** - * Slightly funky test case with a custom Before annotation - */ +/** Slightly funky test case with a custom Before annotation */ @RunWith(JUnit4.class) public class JUnit4SetUpNotRunPositiveCaseCustomBefore { // This will compile-fail and suggest the import of org.junit.Before // BUG: Diagnostic contains: @Before - @Before public void setUp() {} + @Before + public void setUp() {} } @interface Before {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TearDownNotRunPositiveCaseCustomAfter.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TearDownNotRunPositiveCaseCustomAfter.java index cbe0263138a..22ab106f288 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TearDownNotRunPositiveCaseCustomAfter.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TearDownNotRunPositiveCaseCustomAfter.java @@ -19,14 +19,13 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; -/** - * Slightly funky test case with a custom After annotation) - */ +/** Slightly funky test case with a custom After annotation) */ @RunWith(JUnit4.class) public class JUnit4TearDownNotRunPositiveCaseCustomAfter { // This will compile-fail and suggest the import of org.junit.After // BUG: Diagnostic contains: @After - @After public void tearDown() {} + @After + public void tearDown() {} } @interface After {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunNegativeCase3.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunNegativeCase3.java index 36e08686358..9df4ac4d469 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunNegativeCase3.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunNegativeCase3.java @@ -20,7 +20,9 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ @RunWith(JUnit4.class) public class JUnit4TestNotRunNegativeCase3 { // Doesn't begin with "test", and doesn't contain any assertion-like method invocations. diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunPositiveCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunPositiveCase1.java index 9f0276ed59e..ce2dfb269ca 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunPositiveCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/JUnit4TestNotRunPositiveCase1.java @@ -19,7 +19,9 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ @RunWith(JUnit4.class) public class JUnit4TestNotRunPositiveCase1 { // BUG: Diagnostic contains: @Test diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/LongLiteralLowerCaseSuffixPositiveCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/LongLiteralLowerCaseSuffixPositiveCase2.java index 8eb32e3bfcd..96333caabf6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/LongLiteralLowerCaseSuffixPositiveCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/LongLiteralLowerCaseSuffixPositiveCase2.java @@ -16,11 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** - * Positive cases for {@link LongLiteralLowerCaseSuffix}. - */ +/** Positive cases for {@link LongLiteralLowerCaseSuffix}. */ public class LongLiteralLowerCaseSuffixPositiveCase2 { - + // This constant string includes non-ASCII characters to make sure that we're not confusing // bytes and chars: @SuppressWarnings("unused") diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailNegativeCases.java index aa7fb1cc9a6..ff923586ea4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailNegativeCases.java @@ -462,9 +462,11 @@ private static void specialFail() {} private static class Logger { - void log() {}; + void log() {} + ; - void info() {}; + void info() {} + ; } private static class Dummy { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailPositiveCases.java index d4ab0267275..d463bb9c6cf 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MissingFailPositiveCases.java @@ -139,9 +139,11 @@ String dummy() { private static class Logger { - void log() {}; + void log() {} + ; - void info() {}; + void info() {} + ; } private static void dummyMethod() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopNegativeCases.java index 849d094428c..280657729bb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopNegativeCases.java @@ -22,7 +22,9 @@ import java.util.concurrent.BlockingQueue; import java.util.concurrent.CopyOnWriteArrayList; -/** @author anishvisaria98@gmail.com (Anish Visaria) */ +/** + * @author anishvisaria98@gmail.com (Anish Visaria) + */ public class ModifyCollectionInEnhancedForLoopNegativeCases { public static void testBasic(ArrayList arr, HashSet set) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopPositiveCases.java index 2cf76ea3268..ec28af1bdaa 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyCollectionInEnhancedForLoopPositiveCases.java @@ -20,7 +20,9 @@ import java.util.LinkedList; import java.util.Map; -/** @author anishvisaria98@gmail.com (Anish Visaria) */ +/** + * @author anishvisaria98@gmail.com (Anish Visaria) + */ public class ModifyCollectionInEnhancedForLoopPositiveCases { public static void testBasic(ArrayList arr, HashSet set) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifySourceCollectionInStreamPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifySourceCollectionInStreamPositiveCases.java index 90883ba15d3..e9df22d6d11 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifySourceCollectionInStreamPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifySourceCollectionInStreamPositiveCases.java @@ -43,8 +43,7 @@ private void mutateStreamSourceMethodReference() { // BUG: Diagnostic contains: .forEach(mutableValues::remove); - getMutableValues() - .parallelStream() + getMutableValues().parallelStream() .map(x -> x + 1) .filter(x -> x < 5) // BUG: Diagnostic contains: diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfNegativeCases.java index 3f5d199a712..b35cc1a11b0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfNegativeCases.java @@ -19,7 +19,9 @@ import java.util.ArrayList; import java.util.List; -/** @author scottjohnson@google.com (Scott Johnson) */ +/** + * @author scottjohnson@google.com (Scott Johnson) + */ public class ModifyingCollectionWithItselfNegativeCases { List a = new ArrayList(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfPositiveCases.java index a5f07669b07..bafd70c2325 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ModifyingCollectionWithItselfPositiveCases.java @@ -19,7 +19,9 @@ import java.util.ArrayList; import java.util.List; -/** @author scottjohnson@google.com (Scott Johnson) */ +/** + * @author scottjohnson@google.com (Scott Johnson) + */ public class ModifyingCollectionWithItselfPositiveCases { List a = new ArrayList(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases.java index a27990c62d7..8fe49899fab 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases.java @@ -19,7 +19,9 @@ import java.util.List; import java.util.stream.Stream; -/** @author @mariasam (Maria Sam) on 7/6/17. */ +/** + * @author @mariasam (Maria Sam) on 7/6/17. + */ class MultipleParallelOrSequentialCallsPositiveCases { public void basicCaseParallel(List list) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases_expected.java index 073f481661a..60fb17de12c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleParallelOrSequentialCallsPositiveCases_expected.java @@ -19,7 +19,9 @@ import java.util.List; import java.util.stream.Stream; -/** @author @mariasam (Maria Sam) on 7/6/17. */ +/** + * @author @mariasam (Maria Sam) on 7/6/17. + */ class MultipleParallelOrSequentialCallsPositiveCases { public void basicCaseParallel(List list) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallNegativeCases.java index f880b710eaa..d0b98887ce7 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallNegativeCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author sulku@google.com (Marsela Sulku) */ +/** + * @author sulku@google.com (Marsela Sulku) + */ public class MultipleUnaryOperatorsInMethodCallNegativeCases { public static void tests(int a, int b, int[] xs) { testMethod(a, b); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallPositiveCases.java index b49098e23cd..aef529aee7d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/MultipleUnaryOperatorsInMethodCallPositiveCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author sulku@google.com (Marsela Sulku) */ +/** + * @author sulku@google.com (Marsela Sulku) + */ public class MultipleUnaryOperatorsInMethodCallPositiveCases { /** these cases do not have suggested fixes */ public static void tests(int a, int b) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NestedInstanceOfConditionsNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NestedInstanceOfConditionsNegativeCases.java index 8f6f7988326..d2320a5c8f2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NestedInstanceOfConditionsNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NestedInstanceOfConditionsNegativeCases.java @@ -92,11 +92,14 @@ public static void nestedInstanceOfPositiveCases() { } /** test class */ - public static class SuperClass {}; + public static class SuperClass {} + ; /** test class */ - public static class SubClass extends SuperClass {}; + public static class SubClass extends SuperClass {} + ; /** test class */ - public static class DisjointClass {}; + public static class DisjointClass {} + ; } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerNegativeCases.java index 9314cb554d7..54d16a31430 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerNegativeCases.java @@ -19,7 +19,9 @@ import com.google.errorprone.annotations.NoAllocation; import java.util.Arrays; -/** @author agoode@google.com (Adam Goode) */ +/** + * @author agoode@google.com (Adam Goode) + */ public class NoAllocationCheckerNegativeCases { // Calling safe methods is fine. @NoAllocation diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerPositiveCases.java index c6821f1f432..193046ecd9a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NoAllocationCheckerPositiveCases.java @@ -18,7 +18,9 @@ import com.google.errorprone.annotations.NoAllocation; -/** @author agoode@google.com (Adam Goode) */ +/** + * @author agoode@google.com (Adam Goode) + */ public class NoAllocationCheckerPositiveCases { // Trigger on new array. @NoAllocation diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationNegativeCases.java index eea1bc7e2b0..9ecfde1e218 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationNegativeCases.java @@ -19,7 +19,9 @@ import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; -/** @author scottjohnson@google.com (Scott Johnsson) */ +/** + * @author scottjohnson@google.com (Scott Johnsson) + */ @NonRuntimeAnnotationNegativeCases.Runtime public class NonRuntimeAnnotationNegativeCases { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationPositiveCases.java index 37af06da18f..89734d648dc 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NonRuntimeAnnotationPositiveCases.java @@ -19,7 +19,9 @@ import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; -/** @author scottjohnson@google.com (Scott Johnsson) */ +/** + * @author scottjohnson@google.com (Scott Johnsson) + */ @NonRuntimeAnnotationPositiveCases.NotSpecified @NonRuntimeAnnotationPositiveCases.NonRuntime public class NonRuntimeAnnotationPositiveCases { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NullablePrimitiveNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NullablePrimitiveNegativeCases.java index 39238b6a783..2c3c1a39023 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NullablePrimitiveNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/NullablePrimitiveNegativeCases.java @@ -18,7 +18,9 @@ import javax.annotation.Nullable; -/** @author sebastian.h.monte@gmail.com (Sebastian Monte) */ +/** + * @author sebastian.h.monte@gmail.com (Sebastian Monte) + */ public class NullablePrimitiveNegativeCases { @Nullable Integer a; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringNegativeCases.java index dc45cb79ac1..5406bb107c0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringNegativeCases.java @@ -18,7 +18,9 @@ import org.joda.time.Duration; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class ObjectToStringNegativeCases { public static final class FinalObjectClassWithoutToString {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringPositiveCases.java index debe86c4eae..c9efa3e0233 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ObjectToStringPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class ObjectToStringPositiveCases { public static final class FinalObjectClassWithoutToString {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringNegativeCases.java index 8aaad743bcc..0840dfa189e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringNegativeCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author mariasam@google.com (Maria Sam) */ +/** + * @author mariasam@google.com (Maria Sam) + */ public class OverrideThrowableToStringNegativeCases { class BasicTest extends Throwable {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases.java index a7ec9a556e8..b5141aead49 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author mariasam@google.com (Maria Sam) */ +/** + * @author mariasam@google.com (Maria Sam) + */ class OverrideThrowableToStringPositiveCases { class BasicTest extends Throwable { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases_expected.java index 690025aaece..5e1f8a7ffac 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverrideThrowableToStringPositiveCases_expected.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author mariasam@google.com (Maria Sam) */ +/** + * @author mariasam@google.com (Maria Sam) + */ class OverrideThrowableToStringPositiveCases { // BUG: Diagnostic contains: override diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase1.java index f4a0d36ffb7..c18b5cc656d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase1.java @@ -14,7 +14,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author cushon@google.com (Liam Miller-Cushon) */ +/** + * @author cushon@google.com (Liam Miller-Cushon) + */ public class OverridesNegativeCase1 { abstract class Base { abstract void varargsMethod(Object... xs); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase2.java index ddd1d2db903..6f0a2fd2cfe 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase2.java @@ -14,7 +14,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author cushon@google.com (Liam Miller-Cushon) */ +/** + * @author cushon@google.com (Liam Miller-Cushon) + */ public class OverridesNegativeCase2 { abstract class Base { abstract void varargsMethod(Object... xs); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase3.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase3.java index 2ede35dd77f..2886012ad6d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase3.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesNegativeCase3.java @@ -14,7 +14,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author cushon@google.com (Liam Miller-Cushon) */ +/** + * @author cushon@google.com (Liam Miller-Cushon) + */ public class OverridesNegativeCase3 { abstract class Base { abstract void arrayMethod(Object[] xs); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase1.java index 7582aa2bbf2..b38f12358fa 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase1.java @@ -14,18 +14,17 @@ package com.google.errorprone.bugpatterns.testdata; - /** - * This tests that the a bug is reported when a method override changes the type of a parameter - * from varargs to array, or array to varargs. It also ensures that the implementation can - * handles cases with multiple parameters, and whitespaces between the square brackets for - * array types. - * + * This tests that the a bug is reported when a method override changes the type of a parameter from + * varargs to array, or array to varargs. It also ensures that the implementation can handles cases + * with multiple parameters, and whitespaces between the square brackets for array types. + * * @author cushon@google.com (Liam Miller-Cushon) */ public class OverridesPositiveCase1 { abstract class Base { abstract void varargsMethod(Object... xs); + abstract void arrayMethod(int x, Object[] xs); } @@ -34,66 +33,70 @@ abstract class Child1 extends Base { // BUG: Diagnostic contains: abstract void arrayMethod(int x, Object[] newNames); abstract void arrayMethod(int x, Object... newNames); } - + abstract class Child2 extends Base { @Override // BUG: Diagnostic contains: abstract void varargsMethod(Object... xs); abstract void varargsMethod(Object[] xs); } - + abstract class Child3 extends Base { @Override // BUG: Diagnostic contains: abstract void varargsMethod(Object... xs); - abstract void varargsMethod(Object[ ] xs); + abstract void varargsMethod(Object[] xs); } abstract class Child4 extends Base { @Override // BUG: Diagnostic contains: abstract void varargsMethod(Object... xs); - abstract void varargsMethod(Object[ ] xs); + abstract void varargsMethod(Object[] xs); } abstract class Child5 extends Base { @Override // BUG: Diagnostic contains: Varargs - abstract void varargsMethod(Object[/**/ ] xs); + abstract void varargsMethod(Object[ /**/] xs); } - + interface Interface { void varargsMethod(Object... xs); + void arrayMethod(Object[] xs); } - + abstract class ImplementsInterface implements Interface { @Override - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: public abstract void varargsMethod(Object[] xs); + @Override - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: public abstract void arrayMethod(Object... xs); } - + abstract class MyBase { abstract void f(Object... xs); + abstract void g(Object[] xs); } - + interface MyInterface { void f(Object[] xs); + void g(Object... xs); } - + abstract class ImplementsAndExtends extends MyBase implements MyInterface { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: public abstract void f(Object... xs); - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: public abstract void g(Object[] xs); } - + abstract class ImplementsAndExtends2 extends MyBase implements MyInterface { - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: public abstract void f(Object[] xs); - // BUG: Diagnostic contains: + // BUG: Diagnostic contains: public abstract void g(Object... xs); } -} \ No newline at end of file +} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase2.java index 02bd182fa3f..682f700abdb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase2.java @@ -14,12 +14,10 @@ package com.google.errorprone.bugpatterns.testdata; - /** * This tests the case where there is a chain of method overrides where the varargs constraint is - * not met, and the root is a varargs parameter. - * TODO(cushon): The original implementation tried to be clever and make this consistent, but - * didn't handle multiple interface inheritance. + * not met, and the root is a varargs parameter. TODO(cushon): The original implementation tried to + * be clever and make this consistent, but didn't handle multiple interface inheritance. * * @author cushon@google.com (Liam Miller-Cushon) */ @@ -45,4 +43,4 @@ abstract class SubThree extends SubTwo { // BUG: Diagnostic contains: abstract void varargsMethod(Object[] newNames); } -} \ No newline at end of file +} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase3.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase3.java index 7da121cc16a..dd599cfadfb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase3.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase3.java @@ -14,12 +14,10 @@ package com.google.errorprone.bugpatterns.testdata; - /** * This tests the case where there is a chain of method overrides where the varargs constraint is - * not met, and the root has an array parameter. - * TODO(cushon): The original implementation tried to be clever and make this consistent, but - * didn't handle multiple interface inheritance. + * not met, and the root has an array parameter. TODO(cushon): The original implementation tried to + * be clever and make this consistent, but didn't handle multiple interface inheritance. * * @author cushon@google.com (Liam Miller-Cushon) */ @@ -45,4 +43,4 @@ abstract class SubThree extends SubTwo { // BUG: Diagnostic contains: abstract void arrayMethod(Object... newNames); } -} \ No newline at end of file +} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase5.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase5.java index fd4d66b5ef1..6d55dbe6a62 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase5.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/OverridesPositiveCase5.java @@ -14,7 +14,6 @@ package com.google.errorprone.bugpatterns.testdata; - /** * @author cushon@google.com (Liam Miller-Cushon) */ @@ -22,6 +21,7 @@ public class OverridesPositiveCase5 { abstract class Base { abstract void varargsMethod(Object[] xs, Object... ys); + abstract void arrayMethod(Object[] xs, Object[] ys); } @@ -31,7 +31,8 @@ abstract class Child1 extends Base { abstract void arrayMethod(Object[] xs, Object... ys); @Override - // BUG: Diagnostic contains: Did you mean 'abstract void varargsMethod(Object[] xs, Object... ys);' + // BUG: Diagnostic contains: Did you mean 'abstract void varargsMethod(Object[] xs, Object... + // ys);' abstract void varargsMethod(Object[] xs, Object[] ys); void foo(Base base) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodNegativeCases.java index 6201dd9c7b0..90fa44d9d5e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class PrimitiveArrayPassedToVarargsMethodNegativeCases { public void intVarargsMethod(int... ints) {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodPositiveCases.java index ce64501d3d8..64c390b0374 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/PrimitiveArrayPassedToVarargsMethodPositiveCases.java @@ -18,7 +18,9 @@ import java.util.Arrays; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class PrimitiveArrayPassedToVarargsMethodPositiveCases { public void objectVarargsMethod(Object... objs) {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredNegativeCases.java index c4fd633094d..b2196924104 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredNegativeCases.java @@ -22,7 +22,9 @@ import java.util.Map; import java.util.function.Function; -/** @author alexeagle@google.com (Alex Eagle) */ +/** + * @author alexeagle@google.com (Alex Eagle) + */ public class ReturnValueIgnoredNegativeCases { private String a = "thing"; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredPositiveCases.java index accc132f451..3faed29eadb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ReturnValueIgnoredPositiveCases.java @@ -24,7 +24,9 @@ import java.util.Arrays; import java.util.Locale; -/** @author alexeagle@google.com (Alex Eagle) */ +/** + * @author alexeagle@google.com (Alex Eagle) + */ public class ReturnValueIgnoredPositiveCases { String a = "thing"; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredNegativeCases.java index c3cd6e23ce1..b2a0fb6025c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredNegativeCases.java @@ -24,7 +24,9 @@ import java.util.HashMap; import java.util.Map; -/** @author friedj@google.com (Jake Fried) */ +/** + * @author friedj@google.com (Jake Fried) + */ public class RxReturnValueIgnoredNegativeCases { interface CanIgnoreMethod { @CanIgnoreReturnValue diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredPositiveCases.java index cb18117c4e9..1d0ef348005 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/RxReturnValueIgnoredPositiveCases.java @@ -25,7 +25,9 @@ import java.util.HashMap; import java.util.Map; -/** @author friedj@google.com (Jake Fried) */ +/** + * @author friedj@google.com (Jake Fried) + */ public class RxReturnValueIgnoredPositiveCases { private static Observable getObservable() { return null; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaNegativeCases.java index 7aaa5d5e9f0..e5eb0d5d753 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaNegativeCases.java @@ -18,7 +18,9 @@ import com.google.common.base.Objects; -/** @author bhagwani@google.com (Sumit Bhagwani) */ +/** + * @author bhagwani@google.com (Sumit Bhagwani) + */ public class SelfEqualsGuavaNegativeCases { private String field; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaPositiveCase.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaPositiveCase.java index 3e0ca4def92..2a95b82e43a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaPositiveCase.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SelfEqualsGuavaPositiveCase.java @@ -18,7 +18,9 @@ import com.google.common.base.Objects; -/** @author alexeagle@google.com (Alex Eagle) */ +/** + * @author alexeagle@google.com (Alex Eagle) + */ public class SelfEqualsGuavaPositiveCase { private String field = ""; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroNegativeCases.java index 4c2f0693a42..17b9fe83979 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroNegativeCases.java @@ -23,7 +23,9 @@ import java.util.List; import java.util.Set; -/** @author glorioso@google.com (Nick Glorioso) */ +/** + * @author glorioso@google.com (Nick Glorioso) + */ public class SizeGreaterThanOrEqualsZeroNegativeCases { private List intList = new ArrayList<>(); private Set intSet = new HashSet<>(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroPositiveCases.java index cf46045c78f..6323bccd0e6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SizeGreaterThanOrEqualsZeroPositiveCases.java @@ -27,7 +27,9 @@ import java.util.Optional; import java.util.Set; -/** @author glorioso@google.com (Nick Glorioso) */ +/** + * @author glorioso@google.com (Nick Glorioso) + */ public class SizeGreaterThanOrEqualsZeroPositiveCases { private List intList = new ArrayList<>(); private Set intSet = new HashSet<>(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionNegativeCases.java index 514c76c4870..dc12f66f9f2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class StaticQualifiedUsingExpressionNegativeCases { public static int staticVar1 = 1; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase1.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase1.java index 3a551c37c6e..e6e3f80517f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase1.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase1.java @@ -18,7 +18,9 @@ import java.math.BigDecimal; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ class MyClass { static int STATIC_FIELD = 42; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase2.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase2.java index 7a991599a96..9ad06b2e82c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase2.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StaticQualifiedUsingExpressionPositiveCase2.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class StaticQualifiedUsingExpressionPositiveCase2 { private static class TestClass { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharNegativeCases.java index f8d949828f8..b832051d3bc 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author lowasser@google.com (Louis Wasserman) */ +/** + * @author lowasser@google.com (Louis Wasserman) + */ public class StringBuilderInitWithCharNegativeCases { { new StringBuilder("a"); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharPositiveCases.java index 64d9461adc7..3d3827ef8f0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/StringBuilderInitWithCharPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author lowasser@google.com (Louis Wasserman) */ +/** + * @author lowasser@google.com (Louis Wasserman) + */ public class StringBuilderInitWithCharPositiveCases { { // BUG: Diagnostic contains: new StringBuilder("a") diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SuppressWarningsDeprecatedPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SuppressWarningsDeprecatedPositiveCases.java index bfa796fc7d7..ab56d12fd75 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SuppressWarningsDeprecatedPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SuppressWarningsDeprecatedPositiveCases.java @@ -49,13 +49,15 @@ public static void positiveCase5() { public static void positiveCase6() { // BUG: Diagnostic contains: @SuppressWarnings("deprecation") @SuppressWarnings("deprecated") - class Foo {}; + class Foo {} + ; } public static void positiveCase7() { // BUG: Diagnostic contains: @SuppressWarnings({"deprecation", "foobarbaz"}) @SuppressWarnings({"deprecated", "foobarbaz"}) - class Foo {}; + class Foo {} + ; } // BUG: Diagnostic contains: @SuppressWarnings(value = "deprecation") diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakNegativeCases.java index 300a09f055c..01c4654dcac 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author irogers@google.com (Ian Rogers) */ +/** + * @author irogers@google.com (Ian Rogers) + */ public class SwigMemoryLeakNegativeCases { private long swigCPtr; protected boolean swigCMemOwn; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakPositiveCases.java index b921b6bf986..47730cc8f44 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/SwigMemoryLeakPositiveCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author irogers@google.com (Ian Rogers) */ +/** + * @author irogers@google.com (Ian Rogers) + */ public class SwigMemoryLeakPositiveCases { private long swigCPtr; protected boolean swigCMemOwn; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopNegativeCases.java index fbe40a2e2de..0ec66eeaf0c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopNegativeCases.java @@ -17,7 +17,9 @@ import java.util.List; -/** @author mariasam@google.com (Maria Sam) on 7/10/17. */ +/** + * @author mariasam@google.com (Maria Sam) on 7/10/17. + */ public class ThreadJoinLoopNegativeCases { public void basicCase(Thread thread) throws InterruptedException { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases.java index 160dbf243f1..3b4f754cc48 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases.java @@ -15,7 +15,9 @@ */ package com.google.errorprone.bugpatterns.testdata; -/** @author mariasam@google.com (Maria Sam) on 7/10/17. */ +/** + * @author mariasam@google.com (Maria Sam) on 7/10/17. + */ class ThreadJoinLoopPositiveCases { public void basicCase(Thread thread) { @@ -49,7 +51,9 @@ public void emptyCatchStatements(Thread thread) { try { // BUG: Diagnostic contains: Uninterruptibles.joinUninterruptibly(thread) thread.join(); - } catch (Exception e) {;; + } catch (Exception e) { + ; + ; } } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases_expected.java index e8c4d4ae5fa..31375fa6f03 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThreadJoinLoopPositiveCases_expected.java @@ -17,7 +17,9 @@ import com.google.common.util.concurrent.Uninterruptibles; -/** @author mariasam@google.com (Maria Sam) on 7/10/17. */ +/** + * @author mariasam@google.com (Maria Sam) on 7/10/17. + */ class ThreadJoinLoopPositiveCases { public void basicCase(Thread thread) { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestNegativeCases.java index b3299d4fcc9..827ea0e61e8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestNegativeCases.java @@ -21,7 +21,9 @@ import java.util.concurrent.CancellationException; import java.util.concurrent.ExecutionException; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ThrowIfUncheckedKnownCheckedTestNegativeCases { void exception(Exception e) { throwIfUnchecked(e); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestPositiveCases.java index 54359077b3e..71e0a59b013 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowIfUncheckedKnownCheckedTestPositiveCases.java @@ -20,7 +20,9 @@ import java.io.IOException; import java.util.concurrent.ExecutionException; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class ThrowIfUncheckedKnownCheckedTestPositiveCases { void simple(IOException e) { // BUG: Diagnostic contains: no-op diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionNegativeCases.java index c5274bc7f3a..dde000dcacb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionNegativeCases.java @@ -18,7 +18,9 @@ import java.io.FileNotFoundException; import java.io.IOException; -/** @author yulissa@google.com (Yulissa Arroyo-Paredes) */ +/** + * @author yulissa@google.com (Yulissa Arroyo-Paredes) + */ public class ThrowsUncheckedExceptionNegativeCases { public void doSomething() { throw new IllegalArgumentException("thrown"); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionPositiveCases.java index 63a50fde1f3..0eb030f3fdd 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/ThrowsUncheckedExceptionPositiveCases.java @@ -17,7 +17,9 @@ import java.io.IOException; -/** @author yulissa@google.com (Yulissa Arroyo-Paredes) */ +/** + * @author yulissa@google.com (Yulissa Arroyo-Paredes) + */ public class ThrowsUncheckedExceptionPositiveCases { // BUG: Diagnostic contains: 'public void doSomething() {' public void doSomething() throws IllegalArgumentException { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowableNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowableNegativeCases.java index 3a19a2f4923..5db8038c58d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowableNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowableNegativeCases.java @@ -22,7 +22,9 @@ import junit.framework.TestCase; import org.junit.Assert; -/** @author adamwos@google.com (Adam Wos) */ +/** + * @author adamwos@google.com (Adam Wos) + */ public class TryFailThrowableNegativeCases { public static void withoutFail() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowablePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowablePositiveCases.java index febabaf3f48..80e6a259bbc 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowablePositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/TryFailThrowablePositiveCases.java @@ -24,7 +24,9 @@ import junit.framework.TestCase; import org.junit.Assert; -/** @author adamwos@google.com (Adam Wos) */ +/** + * @author adamwos@google.com (Adam Wos) + */ public class TryFailThrowablePositiveCases { public static void emptyCatch_failNoMessage() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsNegativeCases.java index 698cc2f1230..f836950b4f1 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsNegativeCases.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ public class UngroupedOverloadsNegativeCases { private int foo; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCovering.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCovering.java index c61fac71f18..d1f4b034b38 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCovering.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCovering.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ public class UngroupedOverloadsPositiveCasesCovering { // BUG: Diagnostic contains: ungrouped overloads of 'foo' diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCoveringOnlyOnFirst.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCoveringOnlyOnFirst.java index 84ab19d9c51..620de842ec0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCoveringOnlyOnFirst.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesCoveringOnlyOnFirst.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ public class UngroupedOverloadsPositiveCasesCoveringOnlyOnFirst { // BUG: Diagnostic contains: Constructors and methods with the same name should appear diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesInterleaved.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesInterleaved.java index e54c8deb1b4..efccc437652 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesInterleaved.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesInterleaved.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ public class UngroupedOverloadsPositiveCasesInterleaved { private int foo; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesMultiple.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesMultiple.java index cf8007f7296..58f8e05e2e4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesMultiple.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesMultiple.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ public class UngroupedOverloadsPositiveCasesMultiple { private int foo; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesSingle.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesSingle.java index 8d614bff12a..0a0c98b9266 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesSingle.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsPositiveCasesSingle.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ public class UngroupedOverloadsPositiveCasesSingle { public void quux() { diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringComments_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringComments_expected.java index b8f1c7ee899..98f56b691aa 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringComments_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringComments_expected.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ class UngroupedOverloadsRefactoringComments { private void bar() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringInterleaved_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringInterleaved_expected.java index 70e61ebcd60..a2847f6100b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringInterleaved_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringInterleaved_expected.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ class UngroupedOverloadsRefactoringInterleaved { public void foo() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringMultiple_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringMultiple_expected.java index 8494c31bb1f..bfe0c78341f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringMultiple_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UngroupedOverloadsRefactoringMultiple_expected.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author hanuszczak@google.com (Łukasz Hanuszczak) */ +/** + * @author hanuszczak@google.com (Łukasz Hanuszczak) + */ class UngroupedOverloadsRefactoringMultiple { public void foo() {} diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases_expected.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases_expected.java index d5e29fcd302..87216d4087c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases_expected.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases_expected.java @@ -16,7 +16,9 @@ package com.google.errorprone.bugpatterns.testdata; -/** @author awturner@google.com (Andy Turner) */ +/** + * @author awturner@google.com (Andy Turner) + */ class UnnecessaryBoxedAssignmentCases { void negative_void() { return; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/WaitNotInLoopPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/WaitNotInLoopPositiveCases.java index 085a5c7d738..bfa77221f99 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/WaitNotInLoopPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/WaitNotInLoopPositiveCases.java @@ -20,7 +20,9 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.locks.Condition; -/** @author eaftan@google.com (Eddie Aftandilian) */ +/** + * @author eaftan@google.com (Eddie Aftandilian) + */ public class WaitNotInLoopPositiveCases { boolean flag = false; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchNegativeCases.java index c3f782c70b3..37730823b75 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchNegativeCases.java @@ -20,7 +20,9 @@ import java.util.Optional; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class TimeUnitMismatchNegativeCases { static final int THE_MILLIS = 0; int startMillis; diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchPositiveCases.java index cbe726bec63..c306279d823 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchPositiveCases.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/time/testdata/TimeUnitMismatchPositiveCases.java @@ -20,7 +20,9 @@ import java.util.Optional; -/** @author cpovirk@google.com (Chris Povirk) */ +/** + * @author cpovirk@google.com (Chris Povirk) + */ public class TimeUnitMismatchPositiveCases { int startMicros; int stopMillis; diff --git a/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressLintNegativeCases.java b/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressLintNegativeCases.java index 74672f42acd..cee2facb06b 100644 --- a/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressLintNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressLintNegativeCases.java @@ -25,7 +25,8 @@ public class SuppressLintNegativeCases { @SuppressLint({"EmptyIf", "EmptyStatement"}) public void testEmptyIf() { int i = 0; - if (i == 10) ; + if (i == 10) + ; { System.out.println("foo"); } diff --git a/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressWarningsNegativeCases.java b/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressWarningsNegativeCases.java index 0a10a2d8076..f82e5f6cadc 100644 --- a/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressWarningsNegativeCases.java +++ b/core/src/test/java/com/google/errorprone/suppress/testdata/SuppressWarningsNegativeCases.java @@ -27,7 +27,8 @@ public class SuppressWarningsNegativeCases { @SuppressWarnings({"EmptyIf", "EmptyStatement"}) public void testEmptyIf() { int i = 0; - if (i == 10) ; + if (i == 10) + ; { System.out.println("foo"); }