From e928daed4b28dc3dbf95b262d03533fed5f5183b Mon Sep 17 00:00:00 2001 From: Stephan Schroevers Date: Tue, 22 Jun 2021 08:00:03 +0200 Subject: [PATCH] Use `ASTHelpers#getFileName` instead --- .../java/com/google/errorprone/bugpatterns/PackageInfo.java | 6 +++--- .../errorprone/bugpatterns/UnnecessarilyFullyQualified.java | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/PackageInfo.java b/core/src/main/java/com/google/errorprone/bugpatterns/PackageInfo.java index 5c8f9ca97ce..829ec3bb560 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/PackageInfo.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/PackageInfo.java @@ -23,8 +23,8 @@ import com.google.errorprone.VisitorState; import com.google.errorprone.bugpatterns.BugChecker.CompilationUnitTreeMatcher; import com.google.errorprone.matchers.Description; +import com.google.errorprone.util.ASTHelpers; import com.sun.source.tree.CompilationUnitTree; -import java.io.File; /** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */ @BugPattern( @@ -37,8 +37,8 @@ public Description matchCompilationUnit(CompilationUnitTree tree, VisitorState s if (tree.getSourceFile() == null) { return NO_MATCH; } - String name = tree.getSourceFile().getName(); - int idx = name.lastIndexOf(File.separatorChar); + String name = ASTHelpers.getFileName(tree); + int idx = name.lastIndexOf('/'); if (idx != -1) { name = name.substring(idx + 1); } diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java index 115063bc447..79d5ef4609f 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java @@ -32,6 +32,7 @@ import com.google.errorprone.bugpatterns.BugChecker.CompilationUnitTreeMatcher; import com.google.errorprone.fixes.SuggestedFix; import com.google.errorprone.matchers.Description; +import com.google.errorprone.util.ASTHelpers; import com.sun.source.tree.CompilationUnitTree; import com.sun.source.tree.IdentifierTree; import com.sun.source.tree.ImportTree; @@ -44,7 +45,6 @@ import com.sun.tools.javac.code.Symbol.PackageSymbol; import com.sun.tools.javac.code.Symbol.TypeSymbol; import com.sun.tools.javac.util.Position; -import java.io.File; import java.util.ArrayList; import java.util.HashSet; import java.util.List; @@ -189,8 +189,8 @@ public Void visitIdentifier(IdentifierTree identifierTree, Void aVoid) { } private static boolean isPackageInfo(CompilationUnitTree tree) { - String name = tree.getSourceFile().getName(); - int idx = name.lastIndexOf(File.separatorChar); + String name = ASTHelpers.getFileName(tree); + int idx = name.lastIndexOf('/'); if (idx != -1) { name = name.substring(idx + 1); }