Skip to content
Permalink
Branch: master
Commits on May 15, 2019
  1. Add another helper method to VisitorState, to handle the common patte…

    awturner authored and ronshapiro committed May 14, 2019
    …rn of tokenizing a region of the source code.
    
    Start using getOffsetTokens{,ForNode} in error prone.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=248044101
  2. ErrorProneToken: allow an offset to be supplied when tokenizing, in o…

    awturner authored and ronshapiro committed May 13, 2019
    …rder that you do not have to keep remembering to add the offset when using the start/end positions.
    
    Add some helper methods to ErrorProneTokens to allow offset tokens to be constructed.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247918343
  3. Add test for one style of 'checkNotNull'.

    donaldchai authored and ronshapiro committed May 13, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247860581
  4. Add a test for (int, TimeUnit) mismatch.

    kluever authored and ronshapiro committed May 13, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247857735
  5. Make the description of AnnotateFormatMethod more ominous, and don't …

    graememorgan authored and ronshapiro committed May 10, 2019
    …emit a fix (that almost certainly won't compile).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247571865
  6. Recognize a sample default annotation in nullness inference

    kevin1e100 authored and ronshapiro committed May 9, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247474607
  7. Instead of calling Subject.actual(), store the actual value in a fiel…

    cpovirk authored and ronshapiro committed May 7, 2019
    …d, and read that.
    
    actual() is being removed.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247096653
  8. Fix Nan-related suggestions in IdentityBinaryExpression.

    nglorioso authored and ronshapiro committed May 7, 2019
    Fixes #1274
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247064659
Commits on May 7, 2019
  1. Migrate from assertThat(foo).named("foo") to assertWithMessage("foo")…

    cpovirk authored and eaftan committed May 6, 2019
    ….that(foo).
    
    (The exact change is slightly different in some cases, like when using custom subjects or check(), but it's always a migration from named(...) to [assert]WithMessage(...).)
    
    named(...) is being removed.
    
    This CL may slightly modify the failure messages produced, but all the old information will still be present.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246869219
  2. Mark OneofDescriptor as immutable in WellKnownMutability.

    rpavy authored and eaftan committed May 6, 2019
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246859660
Commits on May 5, 2019
  1. Remove references to CheckedFuture from open-source code.

    cpovirk authored and ronshapiro committed May 1, 2019
    The type is being removed from Guava.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246165438
  2. Enable EmptyBlockTag.

    graememorgan authored and ronshapiro committed May 1, 2019
    And fill out the description a bit more to explain why we might not favour this pattern.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246105173
  3. Migrate from is(Not)SameAs to is(Not)SameInstanceAs.

    cpovirk authored and ronshapiro committed May 1, 2019
    They behave identically, and the old names are being removed.
    
    Open-source note: The new methods are available in Truth as of version 0.44.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246076308
  4. Update compile-testing version

    cushon authored and ronshapiro committed Apr 30, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245993057
  5. SameNameButDifferent: suggest qualifying cases where the same simple …

    graememorgan authored and ronshapiro committed Apr 30, 2019
    …name is used to refer to different types within a file.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245919677
  6. Add a null check to FieldCanBeFinal.FinalScanner.visitVariable().

    kluever authored and ronshapiro committed Apr 30, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245876404
  7. Remove SupressionInfo.isNameSuppressed() which appears to be unused

    ronshapiro committed Apr 29, 2019
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245841628
  8. Record time spent in individual Error Prone checks

    cushon authored and ronshapiro committed Apr 29, 2019
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245821511
  9. Only run TryFailRefactoring on test methods

    cushon authored and ronshapiro committed Apr 28, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245665050
  10. SuggestedFixes#renameMethodInvocation: tokenize so as to handle type …

    graememorgan authored and ronshapiro committed Apr 25, 2019
    …args.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245202840
  11. Rename SelfEquals test files for Guava and remove custom TEST_RESOURC…

    sumitbhagwani authored and ronshapiro committed Apr 25, 2019
    …ES setting in BUILD file
    
    GuavaSelfEquals -> SelfEqualsGuava
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245158267
  12. Don't flag lite enums wrapped in GeneratedMessage

    sumitbhagwani authored and ronshapiro committed Apr 25, 2019
    RELNOTES: Don't flag lite enums wrapped in GeneratedMessage
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245148153
  13. Update to Truth 0.44.

    cpovirk authored and ronshapiro committed Apr 24, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245113919
  14. Test cases for lite proto enum value of matches enclosed in lite and …

    sumitbhagwani authored and ronshapiro committed Apr 24, 2019
    …full proto
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245066374
  15. Fix the finding position for unused reassignments.

    graememorgan authored and ronshapiro committed Apr 24, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=245015769
  16. Add a check to detect anonymous classes that can be replaced with met…

    cushon authored and ronshapiro committed Apr 23, 2019
    …hod references
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244896633
  17. OptionalMapToOptional: don't crash on raw types.

    graememorgan authored and ronshapiro committed Apr 23, 2019
    Somewhat interesting this didn't come up internally.
    
    Fixes external #1260
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244822595
  18. Don't flag AutoValue generated code for LiteEnumValueOf check.

    sumitbhagwani authored and ronshapiro committed Apr 22, 2019
    RELNOTES: Don't flag AutoValue generated code for LiteEnumValueOf check.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244687752
  19. Recognize bound type parameters when null-checking method call arguments

    kevin1e100 authored and ronshapiro committed Apr 20, 2019
    discovered due to #1253
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244448935
  20. Simplify @generated handling

    cushon authored and ronshapiro committed Apr 19, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244378908
  21. Migrate Truth Subjects from no-arg check() to the overload that accep…

    cpovirk authored and ronshapiro committed Apr 18, 2019
    …ts a description.
    
    The overload that accepts a description generally produces better failure messages:
    - The first line of the message it produces is something like: "value of: myProto.getResponse()" (where "getResponse()" is taken from the provided description)
    - The last line of the message it produces is something like: "myProto was: response: query was throttled" (the full value of myProto)
    - And the existing text goes in between.
    
    Additional motivation: We have deprecated the no-arg overload in open-source Truth.
    
    Note that the new overload is available externally as of Truth 0.40.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244226097
  22. Add notes about the semantic impact of applying the suggested fix.

    amalloy authored and ronshapiro committed Apr 18, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244218403
  23. Ignore @Bind-annotated fields in UnnecessaryLambda

    cushon authored and ronshapiro committed Apr 18, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244213859
Commits on Apr 18, 2019
  1. Fix protos

    cushon committed Apr 18, 2019
  2. Move MockitoInternalUsage checker to the Mockito open source errorpro…

    TimvdLippe authored and cushon committed Apr 18, 2019
    …ne plugins
    
    This checker is opensourced at mockito/mockito#1690
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=244160840
Older
You can’t perform that action at this time.