Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-source enforcement for `@DoNotMock` #572

Closed
cushon opened this issue Mar 13, 2017 · 3 comments

Comments

@cushon
Copy link
Contributor

@cushon cushon commented Mar 13, 2017

see: https://groups.google.com/d/topic/error-prone-discuss/ZlqF85kcB_w/discussion

This probably needs a customizable whitelisting mechanism to be useful, similar to #512.

@kageiit

This comment has been minimized.

Copy link

@kageiit kageiit commented Apr 3, 2017

Any update on this? Really excited to be able to start using this :)

@msridhar

This comment has been minimized.

Copy link
Contributor

@msridhar msridhar commented Aug 3, 2017

A ping on this one; it keeps coming up for us. I think the whitelisting could be achieved via the new command-line arguments functionality?

ejona86 added a commit to ejona86/grpc-java that referenced this issue Jul 19, 2018
DoNotMock was removed from error_prone_annotations in 2.1.3, because
there was no enforcement mechanism (which is in google/error-prone#572).
Guava and Trust also depend on error_prone_annotations and are beginning
to use newer versions, so our usage of DoNotMock is causing diamond
dependency problems. This allows us to update to 2.2.0.

The annotations were useful internally; we're solving that in cl/205294089.
ejona86 added a commit to grpc/grpc-java that referenced this issue Jul 20, 2018
DoNotMock was removed from error_prone_annotations in 2.1.3, because
there was no enforcement mechanism (which is in google/error-prone#572).
Guava and Trust also depend on error_prone_annotations and are beginning
to use newer versions, so our usage of DoNotMock is causing diamond
dependency problems. This allows us to update to 2.2.0.

The annotations were useful internally; we're solving that in cl/205294089.
@amalloy

This comment has been minimized.

Copy link
Member

@amalloy amalloy commented Aug 28, 2019

This was done in db307bc. Sorry it didn't occur to me to close this issue at the time.

@amalloy amalloy closed this Aug 28, 2019
treenewtreenew added a commit to treenewtreenew/grpc-java that referenced this issue Oct 7, 2019
DoNotMock was removed from error_prone_annotations in 2.1.3, because
there was no enforcement mechanism (which is in google/error-prone#572).
Guava and Trust also depend on error_prone_annotations and are beginning
to use newer versions, so our usage of DoNotMock is causing diamond
dependency problems. This allows us to update to 2.2.0.

The annotations were useful internally; we're solving that in cl/205294089.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.