diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/time/PreferJavaTimeOverload.java b/core/src/main/java/com/google/errorprone/bugpatterns/time/PreferJavaTimeOverload.java index fe8d0a02cf1..ee9529193bc 100644 --- a/core/src/main/java/com/google/errorprone/bugpatterns/time/PreferJavaTimeOverload.java +++ b/core/src/main/java/com/google/errorprone/bugpatterns/time/PreferJavaTimeOverload.java @@ -17,8 +17,10 @@ import static com.google.errorprone.BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION; import static com.google.errorprone.BugPattern.SeverityLevel.WARNING; +import static com.google.errorprone.matchers.Matchers.allOf; import static com.google.errorprone.matchers.Matchers.anyOf; import static com.google.errorprone.matchers.Matchers.constructor; +import static com.google.errorprone.matchers.Matchers.toType; import static com.google.errorprone.matchers.method.MethodMatchers.instanceMethod; import static com.google.errorprone.matchers.method.MethodMatchers.staticMethod; import static com.google.errorprone.util.ASTHelpers.getSymbol; @@ -111,7 +113,13 @@ public final class PreferJavaTimeOverload extends BugChecker private static final Matcher IGNORED_APIS = anyOf( - staticMethod().onClass("org.assertj.core.api.Assertions").named("assertThat")); + allOf( + staticMethod().anyClass().named("assertThat"), + toType(MethodInvocationTree.class, (Matcher) (methodInvocationTree, state) -> + isSubtype( + ASTHelpers.getReturnType(methodInvocationTree), + state.getTypeFromString("org.assertj.core.api.Assert"), + state)))); private static final Matcher JAVA_DURATION_DECOMPOSITION_MATCHER = anyOf(