From 8d4c117d2fa4417959480a30b9a37cac3258610b Mon Sep 17 00:00:00 2001
From: Kurt Alfred Kluever <kak@google.com>
Date: Wed, 13 May 2026 00:17:59 -0700
Subject: [PATCH] JUnit3 test methods in fact _can_ be `static` (and will still
 get run by the test runner!).

PiperOrigin-RevId: 914692547
---
 .../com/google/errorprone/matchers/JUnitMatchers.java  |  2 --
 .../errorprone/bugpatterns/JUnit3TestNotRunTest.java   | 10 +---------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/check_api/src/main/java/com/google/errorprone/matchers/JUnitMatchers.java b/check_api/src/main/java/com/google/errorprone/matchers/JUnitMatchers.java
index e362fa2024d..0c3a9d9ed7f 100644
--- a/check_api/src/main/java/com/google/errorprone/matchers/JUnitMatchers.java
+++ b/check_api/src/main/java/com/google/errorprone/matchers/JUnitMatchers.java
@@ -155,7 +155,6 @@ private static boolean hasJUnitAttr(MethodSymbol methodSym) {
    *   <li>The method's name begins with "test".
    *   <li>The method has no parameters.
    *   <li>The method is public.
-   *   <li>The method is not static.
    *   <li>The method returns void.
    * </ol>
    */
@@ -164,7 +163,6 @@ private static boolean hasJUnitAttr(MethodSymbol methodSym) {
           methodNameStartsWith("test"),
           methodHasNoParameters(),
           Matchers.<MethodTree>hasModifier(Modifier.PUBLIC),
-          not(Matchers.<MethodTree>hasModifier(Modifier.STATIC)),
           methodReturns(VOID_TYPE));
 
   /** Common matcher for possible JUnit setUp/tearDown methods. */
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java
index 20aa9d80f99..e5d87ee8636 100644
--- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java
+++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java
@@ -215,15 +215,7 @@ public class KansasGlobalMetadataUtilsTest extends TestCase {
               public static void testParseGlobalMetadata() {}
             }
             """)
-        .addOutputLines(
-            "out/KansasGlobalMetadataUtilsTest.java",
-            """
-            import junit.framework.TestCase;
-
-            public class KansasGlobalMetadataUtilsTest extends TestCase {
-              public void testParseGlobalMetadata() {}
-            }
-            """)
+        .expectUnchanged()
         .doTest();
   }