Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issues under ubuntu 20 and latest clang #2562

Merged
merged 2 commits into from May 24, 2020

Conversation

neshume
Copy link
Contributor

@neshume neshume commented May 20, 2020

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@romainguy romainguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission but this is a third party library. We need to track such changes in our README (see tnt/ subdirectory) and/or move to a newer version of this library. Otherwise we'll break it next time we update it.

@neshume
Copy link
Contributor Author

neshume commented May 20, 2020

Thx guy.
I will fix that directly in the 3rd party and submit pull request there so that when you update it will be fixed. 👍🙏

@romainguy romainguy mentioned this pull request May 23, 2020
@romainguy romainguy merged commit 6df1265 into google:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants