Skip to content

gltfio: support material extras - #4400

Merged
prideout merged 3 commits into
google:mainfrom
alexey-pelykh:material_extras
Jan 25, 2022
Merged

prideout merged 3 commits into
google:mainfrom
alexey-pelykh:material_extras

Conversation

@alexey-pelykh

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla

google-cla Bot commented Jul 28, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Comment thread libs/gltfio/src/AssetLoader.cpp
Comment thread libs/gltfio/src/AssetLoader.cpp
Comment thread third_party/models/BusterDrone/scene.gltf Outdated
Comment thread libs/gltfio/src/AssetLoader.cpp Outdated
@alexey-pelykh
alexey-pelykh requested a review from bejado August 4, 2021 13:34
@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

Change requests have been addressed

@prideout prideout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's been a loooong time (my apologies) but I actually think we can merge this PR, it's a useful feature and not dangerous.

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

@prideout do you need me to rebase it and/or do anything else?

@prideout

Copy link
Copy Markdown
Contributor

@prideout do you need me to rebase it and/or do anything else?

Nope, we can merge this after we cut our next release (which will likely be Tuesday).

@prideout
prideout merged commit 45054ee into google:main Jan 25, 2022
@alexey-pelykh
alexey-pelykh deleted the material_extras branch January 25, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants