Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add option to skip verifying nested flatbuffers #7489

Merged
merged 6 commits into from
Aug 29, 2022

Conversation

CasperN
Copy link
Collaborator

@CasperN CasperN commented Aug 29, 2022

Additionally, add an options struct to the verifier for those
who prefer designated initializers to default arguments. The former
constructor is defined in terms of the latter because in old c++,
having default values for members removes list initialization, making
defining constructors in the other way a lot more challenging to write.

@dbaileychess

Additionally, add an options struct to the verifier for those
who prefer designated initializers to default arguments. The former
constructor is defined in terms of the latter because in old c++,
having default values for members removes list initialization, making
defining constructors in the other way a lot more challenging to write.
@github-actions github-actions bot added the c++ label Aug 29, 2022
Copy link
Collaborator

@dbaileychess dbaileychess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

include/flatbuffers/verifier.h Outdated Show resolved Hide resolved
include/flatbuffers/verifier.h Outdated Show resolved Hide resolved
include/flatbuffers/verifier.h Outdated Show resolved Hide resolved
include/flatbuffers/verifier.h Outdated Show resolved Hide resolved
include/flatbuffers/verifier.h Show resolved Hide resolved
Casper Neo added 2 commits August 29, 2022 17:10
include/flatbuffers/verifier.h Show resolved Hide resolved
include/flatbuffers/verifier.h Outdated Show resolved Hide resolved
@dbaileychess dbaileychess merged commit 41d9add into google:master Aug 29, 2022
@CasperN CasperN deleted the verifier-options branch August 30, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants